From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWEZK-0001Bd-Rn
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:12:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWEZC-00018V-HV
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:12:04 -0400
Received: from [199.232.76.173] (port=40901 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWEZC-00018R-D2
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:11:58 -0400
Received: from mx20.gnu.org ([199.232.41.8]:37655)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MWEZC-0001OE-BS
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:11:58 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MWEZA-0000Qb-Vc
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 15:11:57 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH v3] make windows notice media change
Date: Wed, 29 Jul 2009 20:11:53 +0100
References: <20090729160902.GG30449@redhat.com>
In-Reply-To: <20090729160902.GG30449@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907292011.54661.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Filip Navara <filip.navara@gmail.com>, Gleb Natapov <gleb@redhat.com>

> -    if (version_id != 2)
> +    if (version_id < 2)
>          return -EINVAL;

This is still wrong. You can not assume future versions will be backward 
compatible.

Paul