From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MZ5EM-0002jB-UR for qemu-devel@nongnu.org; Thu, 06 Aug 2009 11:50:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MZ5EI-0002dp-IX for qemu-devel@nongnu.org; Thu, 06 Aug 2009 11:50:14 -0400 Received: from [199.232.76.173] (port=34349 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MZ5EI-0002dc-AZ for qemu-devel@nongnu.org; Thu, 06 Aug 2009 11:50:10 -0400 Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:27753 helo=SMTP.EU.CITRIX.COM) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MZ5EH-0001GA-PZ for qemu-devel@nongnu.org; Thu, 06 Aug 2009 11:50:10 -0400 From: Bique Alexandre Date: Thu, 6 Aug 2009 16:48:20 +0100 References: <200908061640.39895.alexandre.bique@citrix.com> In-Reply-To: <200908061640.39895.alexandre.bique@citrix.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_EtveKpCXztLC+mw" Message-ID: <200908061648.20407.alexandre.bique@citrix.com> Subject: [Qemu-devel] [PATCH 2/4] ATAPI pass through v3 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" --Boundary-00=_EtveKpCXztLC+mw Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Few comments -- Alexandre Bique --Boundary-00=_EtveKpCXztLC+mw Content-Type: text/x-patch; charset="UTF-8"; name="atapi-comments" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="atapi-comments" diff --git a/hw/ide.c b/hw/ide.c index 1e56786..16ca80c 100644 --- a/hw/ide.c +++ b/hw/ide.c @@ -1664,9 +1664,9 @@ static void ide_atapi_cmd(IDEState *s) switch(action) { case 0: /* current values */ switch(code) { - case 0x01: /* error recovery */ + case 0x01: /* read write error recovery parameters */ cpu_to_ube16(&buf[0], 16 + 6); - buf[2] = 0x70; + buf[2] = 0x70; /* Obsolete: medium type code */ buf[3] = 0; buf[4] = 0; buf[5] = 0; @@ -1683,17 +1683,17 @@ static void ide_atapi_cmd(IDEState *s) buf[15] = 0x00; ide_atapi_cmd_reply(s, 16, max_len); break; - case 0x2a: + case 0x2a: /* CD/DVD capabilities & mechanical status */ cpu_to_ube16(&buf[0], 28 + 6); - buf[2] = 0x70; + buf[2] = 0x70; /* Obsolete: medium type code */ buf[3] = 0; buf[4] = 0; buf[5] = 0; buf[6] = 0; buf[7] = 0; - buf[8] = 0x2a; - buf[9] = 0x12; + buf[8] = 0x2a; /* page code */ + buf[9] = 0x12; /* page length */ buf[10] = 0x00; buf[11] = 0x00; --Boundary-00=_EtveKpCXztLC+mw--