qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: aliguori@us.ibm.com, filip.navara@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/3] Introduce QNumber data type
Date: Thu, 6 Aug 2009 18:21:39 -0300	[thread overview]
Message-ID: <20090806182139.27846117@doriath> (raw)
In-Reply-To: <4A7AE302.30304@redhat.com>

On Thu, 06 Aug 2009 17:04:50 +0300
Avi Kivity <avi@redhat.com> wrote:

> On 08/06/2009 04:52 PM, Luiz Capitulino wrote:
> > +
> > +typedef struct QNumber {
> > +    QObject base;
> > +    union {
> > +        int n_int;
> > +        int64_t n_int64;
> > +    } number;
> > +} QNumber;
> >    
> 
> Why not have an int64_t exclusively?

 Something I was wondering: why does get_expr() use int64_t
instead of uint64_t?

 As far as I can understand it uses strtoull() and strtoul() to
convert from the user's string and command handlers use 64-bits
values only for addresses and (signed) 32-bits for anything else.

 We are doing some int64_t to uint64_t conversions today...

  parent reply	other threads:[~2009-08-06 21:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 13:52 [Qemu-devel] [PATCH RFC 0/3] QEMU Object Model Luiz Capitulino
2009-08-06 13:52 ` [Qemu-devel] [PATCH 1/3] Introduce qobject header file Luiz Capitulino
2009-08-06 14:02   ` [Qemu-devel] " Avi Kivity
2009-08-06 14:07     ` Luiz Capitulino
2009-08-06 15:54   ` [Qemu-devel] " malc
2009-08-06 13:52 ` [Qemu-devel] [PATCH 2/3] Introduce QString data type Luiz Capitulino
2009-08-06 13:52 ` [Qemu-devel] [PATCH 3/3] Introduce QNumber " Luiz Capitulino
2009-08-06 14:04   ` [Qemu-devel] " Avi Kivity
2009-08-06 14:05     ` François Revol
2009-08-06 14:48       ` Avi Kivity
2009-08-06 14:10     ` Luiz Capitulino
2009-08-06 21:21     ` Luiz Capitulino [this message]
2009-08-06 14:06 ` [Qemu-devel] Re: [PATCH RFC 0/3] QEMU Object Model Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090806182139.27846117@doriath \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=filip.navara@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).