From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: virtio-blk performance and MSI
Date: Sun, 9 Aug 2009 22:53:45 +0300 [thread overview]
Message-ID: <20090809195345.GA21703@redhat.com> (raw)
In-Reply-To: <20090809191313.GA23446@lst.de>
On Sun, Aug 09, 2009 at 09:13:13PM +0200, Christoph Hellwig wrote:
> On Sun, Aug 09, 2009 at 08:49:23PM +0300, Avi Kivity wrote:
> > Sorry, confused. Upstream doesn't use kvm for msi (everything's done in
> > userspace). What exactly blocks us here?
>
> Hmm, good question. Michael, do you know if we can just enabled
> MSI unconditionally in upstream qemu, or are there guests that can't
> cope with it?
Upstream or not, block should request MSI by default, the code in hw/msi
checks that host kernel can support it and only enables when it's safe.
And AFAIK all guests can cope with it but only if they are rebooted.
So we must have a flag to change the # of vectors, to have ability
to load images and migrate from state stored by old qemu.
And of course this option is also useful for troubleshooting.
--
MST
next prev parent reply other threads:[~2009-08-09 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 16:35 [Qemu-devel] virtio-blk performance and MSI Christoph Hellwig
2009-08-09 10:01 ` [Qemu-devel] " Avi Kivity
2009-08-09 17:41 ` Christoph Hellwig
2009-08-09 17:49 ` Avi Kivity
2009-08-09 19:13 ` Christoph Hellwig
2009-08-09 19:53 ` Michael S. Tsirkin [this message]
2009-08-09 19:49 ` Michael S. Tsirkin
2009-08-09 19:56 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090809195345.GA21703@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).