From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qdev: add return value to init() callbacks.
Date: Wed, 12 Aug 2009 20:28:40 +0100 [thread overview]
Message-ID: <200908122028.41012.paul@codesourcery.com> (raw)
In-Reply-To: <1250092766-23986-1-git-send-email-kraxel@redhat.com>
> We have already one case in-tree where this is needed:
> Try -device virtio-blk-pci (without drive= specified) and watch qemu
> segfault.
No. Failure of the init routine should be fatal. i.e. virtio_blk_init_pci
should call hw_error.
If you want to allow graceful failure (which is pointless for commandline
options, but may be desirable for hotplug devices) they you need to also add
some way of reporting why device creation failure. fprintf(stderr) is just
plain wrong.
Paul
next prev parent reply other threads:[~2009-08-12 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 15:59 [Qemu-devel] [PATCH] qdev: add return value to init() callbacks Gerd Hoffmann
2009-08-12 17:00 ` Markus Armbruster
2009-08-12 19:28 ` Paul Brook [this message]
2009-08-12 19:47 ` Gerd Hoffmann
2009-08-13 6:17 ` Markus Armbruster
2009-08-13 7:48 ` Gerd Hoffmann
2009-08-13 9:06 ` Markus Armbruster
2009-08-13 11:05 ` Gerd Hoffmann
2009-08-13 11:42 ` Markus Armbruster
2009-08-13 14:31 ` Gerd Hoffmann
2009-08-13 17:22 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908122028.41012.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).