From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MbgOY-0007VC-Lh
	for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:55:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MbgOT-0007Sk-1d
	for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:55:29 -0400
Received: from [199.232.76.173] (port=51767 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MbgOS-0007Sh-VJ
	for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:55:24 -0400
Date: Thu, 13 Aug 2009 22:55:17 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] save/restore broken?
Message-ID: <20090813195517.GB4636@redhat.com>
References: <h5s6sk$ema$1@ger.gmane.org> <20090813154827.409ed832@doriath>
	<4A8462A8.1020206@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A8462A8.1020206@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <bonzini@gnu.org>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On Thu, Aug 13, 2009 at 01:59:52PM -0500, Anthony Liguori wrote:
> Luiz Capitulino wrote:
> >On Tue, 11 Aug 2009 18:39:47 +0200
> >Paolo Bonzini <bonzini@gnu.org> wrote:
> >
> >>Hi all,
> >>
> >>if I try to save and restore an image using current qemu and
> >>current libvirt, the load fails.
> >
> > Yes, it's broken. I'm unable to loadvm and to migrate.
> >
> > According to git bisect the problem was introduced by:
> This should fix it.
> 
> Regards,
> 
> Anthony Liguori

> commit a536948b3805a311f274b119c5202fdc86504cf3
> Author: Anthony Liguori <aliguori@us.ibm.com>
> Date:   Thu Aug 13 13:58:21 2009 -0500
> 
>     Fix migration for ide devices
>     
>     commit 93c8cfd9e67a62711b86f4c93747566885eb7928
>     Author: Gleb Natapov <gleb@redhat.com>
>     Date:   Sun Aug 2 11:36:47 2009 +0300
>     
>         make windows notice media change
>     
>     Broke save/restore by loading a new field but not saving it.
>     
>     Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> diff --git a/hw/ide.c b/hw/ide.c
> index bebda7c..1e38ae3 100644
> --- a/hw/ide.c
> +++ b/hw/ide.c
> @@ -2888,6 +2888,7 @@ static void ide_save(QEMUFile* f, IDEState *s)
>  
>      qemu_put_8s(f, &s->sense_key);
>      qemu_put_8s(f, &s->asc);
> +    qemu_put_8s(f, &s->cdrom_changed);
>      /* XXX: if a transfer is pending, we do not save it yet */
>  }
>  
Yap. Got lost between v3 and v4 of the patch :(


--
			Gleb.