From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mbwj7-0005pk-Ub
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 09:21:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mbwj2-0005nZ-VN
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 09:21:49 -0400
Received: from [199.232.76.173] (port=52991 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mbwj2-0005nO-Ox
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 09:21:44 -0400
Received: from mx2.redhat.com ([66.187.237.31]:55477)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1Mbwga-0004Vs-QK
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 09:19:13 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7EDJ8CX011887
	for <qemu-devel@nongnu.org>; Fri, 14 Aug 2009 09:19:09 -0400
Date: Fri, 14 Aug 2009 16:19:06 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] kvm: bios: advertise pci irqs as
	active high
Message-ID: <20090814131906.GA16448@redhat.com>
References: <1250252518-29300-1-git-send-email-kraxel@redhat.com>
	<1250252518-29300-2-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1250252518-29300-2-git-send-email-kraxel@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On Fri, Aug 14, 2009 at 02:21:53PM +0200, Gerd Hoffmann wrote:
> From: Avi Kivity <avi@qumranet.com>
> 
> now that kvm emulates the ioapic polarity correctly, we must describe
kvm yes, but qemu doesn't. It make sense to fix qemu polarity handling
in the same series. Otherwise this patch does nothing.

> the polarity correctly in the acpi tables.  otherwise pci interrupts won't
> be delivered correctly.
> 
> Signed-off-by: Avi Kivity <avi@qumranet.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  acpi-dsdt.dsl |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/acpi-dsdt.dsl b/acpi-dsdt.dsl
> index 7bff30a..76ff100 100644
> --- a/acpi-dsdt.dsl
> +++ b/acpi-dsdt.dsl
> @@ -441,7 +441,7 @@ DefinitionBlock (
>                  Name(_HID, EISAID("PNP0C0F"))     // PCI interrupt link
>                  Name(_UID, 1)
>                  Name(_PRS, ResourceTemplate(){
> -                    IRQ (Level, ActiveLow, Shared)
> +                    IRQ (Level, ActiveHigh, Shared)
>                          {3,4,5,6,7,9,10,11,12}
>                  })
>                  Method (_STA, 0, NotSerialized)
> @@ -461,7 +461,7 @@ DefinitionBlock (
>                  {
>                      Name (PRR0, ResourceTemplate ()
>                      {
> -                        IRQ (Level, ActiveLow, Shared)
> +                        IRQ (Level, ActiveHigh, Shared)
>                              {1}
>                      })
>                      CreateWordField (PRR0, 0x01, TMP)
> @@ -488,7 +488,7 @@ DefinitionBlock (
>                  Name(_HID, EISAID("PNP0C0F"))     // PCI interrupt link
>                  Name(_UID, 2)
>                  Name(_PRS, ResourceTemplate(){
> -                    IRQ (Level, ActiveLow, Shared)
> +                    IRQ (Level, ActiveHigh, Shared)
>                          {3,4,5,6,7,9,10,11,12}
>                  })
>                  Method (_STA, 0, NotSerialized)
> @@ -508,7 +508,7 @@ DefinitionBlock (
>                  {
>                      Name (PRR0, ResourceTemplate ()
>                      {
> -                        IRQ (Level, ActiveLow, Shared)
> +                        IRQ (Level, ActiveHigh, Shared)
>                              {1}
>                      })
>                      CreateWordField (PRR0, 0x01, TMP)
> @@ -535,7 +535,7 @@ DefinitionBlock (
>                  Name(_HID, EISAID("PNP0C0F"))     // PCI interrupt link
>                  Name(_UID, 3)
>                  Name(_PRS, ResourceTemplate(){
> -                    IRQ (Level, ActiveLow, Shared)
> +                    IRQ (Level, ActiveHigh, Shared)
>                          {3,4,5,6,7,9,10,11,12}
>                  })
>                  Method (_STA, 0, NotSerialized)
> @@ -555,7 +555,7 @@ DefinitionBlock (
>                  {
>                      Name (PRR0, ResourceTemplate ()
>                      {
> -                        IRQ (Level, ActiveLow, Shared)
> +                        IRQ (Level, ActiveHigh, Shared)
>                              {1}
>                      })
>                      CreateWordField (PRR0, 0x01, TMP)
> @@ -582,7 +582,7 @@ DefinitionBlock (
>                  Name(_HID, EISAID("PNP0C0F"))     // PCI interrupt link
>                  Name(_UID, 4)
>                  Name(_PRS, ResourceTemplate(){
> -                    IRQ (Level, ActiveLow, Shared)
> +                    IRQ (Level, ActiveHigh, Shared)
>                          {3,4,5,6,7,9,10,11,12}
>                  })
>                  Method (_STA, 0, NotSerialized)
> @@ -602,7 +602,7 @@ DefinitionBlock (
>                  {
>                      Name (PRR0, ResourceTemplate ()
>                      {
> -                        IRQ (Level, ActiveLow, Shared)
> +                        IRQ (Level, ActiveHigh, Shared)
>                              {1}
>                      })
>                      CreateWordField (PRR0, 0x01, TMP)
> -- 
> 1.6.2.5
> 
> 

--
			Gleb.