Re: [Qemu-devel] [PATCH 1/6] kvm: bios: advertise pci irqs as active high

[Gleb Natapov <gleb@redhat.com>]

On Fri, Aug 14, 2009 at 03:59:41PM +0200, Gerd Hoffmann wrote:
> On 08/14/09 15:19, Gleb Natapov wrote:
> >On Fri, Aug 14, 2009 at 02:21:53PM +0200, Gerd Hoffmann wrote:
> >>From: Avi Kivity<avi@qumranet.com>
> >>
> >>now that kvm emulates the ioapic polarity correctly, we must describe
> >kvm yes, but qemu doesn't. It make sense to fix qemu polarity handling
> >in the same series.
> 
> Same series doesn't work.  These patches are for the pcbios git tree.
> 
We already have pcbios git tree. Cool.

> Of course it makes sense to get more features and fixes from kvm
> merged upstream.  Feel free to join the party to speed this up ;)
> 
kvm implements polarity in in-kernel ioapic, not in qemu one. It should
be very simple though. I though may be while you are at it... :)

> >Otherwise this patch does nothing.
> 
> It doesn't hurt though and reduces the differences between qemu and
> kvm, which is a good thing.  Also note that the other patches which
> fix real bugs depend on this one.
> 
Can you elaborate which one fixes what bugs? I am not at all against
those patches going into qemu, just curious. AFAIK current bios works
with qemu as is.

--
			Gleb.