From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mbzz1-0002Ee-Mm
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 12:50:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mbzyw-0002ER-7J
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 12:50:26 -0400
Received: from [199.232.76.173] (port=51598 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mbzyw-0002EO-12
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 12:50:22 -0400
Received: from mx2.redhat.com ([66.187.237.31]:50990)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1Mbzyv-0002RI-GT
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 12:50:21 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7EGoKJG022614
	for <qemu-devel@nongnu.org>; Fri, 14 Aug 2009 12:50:20 -0400
Date: Fri, 14 Aug 2009 19:50:18 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] kvm: bios: advertise pci irqs as
	active high
Message-ID: <20090814165018.GB16448@redhat.com>
References: <1250252518-29300-1-git-send-email-kraxel@redhat.com>
	<1250252518-29300-2-git-send-email-kraxel@redhat.com>
	<20090814131906.GA16448@redhat.com> <4A856DCD.8050704@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A856DCD.8050704@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On Fri, Aug 14, 2009 at 03:59:41PM +0200, Gerd Hoffmann wrote:
> On 08/14/09 15:19, Gleb Natapov wrote:
> >On Fri, Aug 14, 2009 at 02:21:53PM +0200, Gerd Hoffmann wrote:
> >>From: Avi Kivity<avi@qumranet.com>
> >>
> >>now that kvm emulates the ioapic polarity correctly, we must describe
> >kvm yes, but qemu doesn't. It make sense to fix qemu polarity handling
> >in the same series.
> 
> Same series doesn't work.  These patches are for the pcbios git tree.
> 
We already have pcbios git tree. Cool.

> Of course it makes sense to get more features and fixes from kvm
> merged upstream.  Feel free to join the party to speed this up ;)
> 
kvm implements polarity in in-kernel ioapic, not in qemu one. It should
be very simple though. I though may be while you are at it... :)

> >Otherwise this patch does nothing.
> 
> It doesn't hurt though and reduces the differences between qemu and
> kvm, which is a good thing.  Also note that the other patches which
> fix real bugs depend on this one.
> 
Can you elaborate which one fixes what bugs? I am not at all against
those patches going into qemu, just curious. AFAIK current bios works
with qemu as is.

--
			Gleb.