qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>,
	Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add tar container format
Date: Sat, 15 Aug 2009 22:36:52 +0200	[thread overview]
Message-ID: <20090815203652.GA22040@lst.de> (raw)
In-Reply-To: <4A849E17.3030901@codemonkey.ws>

On Thu, Aug 13, 2009 at 06:13:27PM -0500, Anthony Liguori wrote:
> What's attractive about doing plugins for the block layer is that we 
> have a relatively stable interface for block drivers.  The current AIO 
> ops should be good for a very long time so API churn shouldn't be a 
> major issue.  The code is all pretty well isolated today.
> 
> As part of the longer term refactoring, I think it also makes sense to 
> split the block layer into a library that can be consumed independent of 
> QEMU.  Obviously, folks want to make use of our block code who don't 
> care at all about QEMU.  A lot of people use qemu-img for vmdk 
> manipulation, for instance.  It also makes tools like qemu-iotest able 
> to consume the block layer in a saner way.
> 
> If others agree, I think we should start going down this road.  
> block-tar/block-dictzip seem like obvious candidates for plugins.

Splitting drivers from the core is a total desaster, you'll end up with
the same crap as the X drivers vs core X server versioning mess.  After
a long stabilization period we might be able to split the block layer
_including_ the drivers from qemu if we really want.  Splitting the
drivers into tiny subpackages would be plain stupid.

As far as additional image formats are concerned I'm personally not a
fan at all of any of that image format crap we have right now.  Anything
like qcow and friends or other formats that do complex metadata
manipulation in userspace is a really bad idea for data integrity.
Supporting simple containers with static metadata is absolutely fine,
even more so it it's read-only like the tar container here.

But one problem with tar is that there are many slightly or even totally
different tar formats and extensions around.  It's not nessecarily a
format I would personally chose for a product.  That's something the
SuSE stuio people should think about, but nothing that should prevent
us from including the format.

  parent reply	other threads:[~2009-08-15 20:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 15:33 [Qemu-devel] [PATCH] Add tar container format Alexander Graf
2009-08-13 22:57 ` Anthony Liguori
2009-08-13 23:08   ` Alexander Graf
2009-08-13 23:13     ` Anthony Liguori
2009-08-13 23:15       ` Anthony Liguori
2009-08-15 20:36       ` Christoph Hellwig [this message]
2009-08-17 12:05     ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090815203652.GA22040@lst.de \
    --to=hch@lst.de \
    --cc=agraf@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).