From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1McxLp-0006bH-FL for qemu-devel@nongnu.org; Mon, 17 Aug 2009 04:13:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1McxLk-0006Yb-GY for qemu-devel@nongnu.org; Mon, 17 Aug 2009 04:13:56 -0400 Received: from [199.232.76.173] (port=45612 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1McxLk-0006YY-23 for qemu-devel@nongnu.org; Mon, 17 Aug 2009 04:13:52 -0400 Received: from mail.gmx.net ([213.165.64.20]:34806) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1McxLj-0002B8-Er for qemu-devel@nongnu.org; Mon, 17 Aug 2009 04:13:51 -0400 Date: Mon, 17 Aug 2009 09:47:06 +0200 From: Reimar =?iso-8859-1?Q?D=F6ffinger?= Subject: Re: [Qemu-devel] [PATCH] Intel 8255x/eepro100 compatibility patches Message-ID: <20090817074706.GA12036@1und1.de> References: <20090809211433.GA8892@1und1.de> <4A7FA3EA.4080804@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <4A7FA3EA.4080804@mail.berlios.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Aug 10, 2009 at 06:36:58AM +0200, Stefan Weil wrote: > this is interesting to me. Maybe you want to try a newer version of > eepro100.c. The latest version is in http://repo.or.cz/w/qemu/ar7.git, > http://repo.or.cz/w/qemu/ar7.git?a=blob;f=hw/eepro100.c > > It has some really important improvements. I want to get it ready > for inclusion in the official QEMU by the end of August. Any hints on what those are? The only ones not in upstream seem mostly cosmetic to me (not that they aren't a good idea), and changing the VM save format, which I think should better wait for further changes, e.g. most of the statistics stuff should not be saved because it is not and for what I can tell stuff like rx_crc_errors never will be used (not to mention the "complete" thing which makes no sense at all to store). I'd suggest a patch, but my local tree is a bit too much of a mess with all those pending patches that I am too lazy.