From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Me7wI-0004EY-Jp for qemu-devel@nongnu.org; Thu, 20 Aug 2009 09:44:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Me7wE-0004Cc-RL for qemu-devel@nongnu.org; Thu, 20 Aug 2009 09:44:26 -0400 Received: from [199.232.76.173] (port=33386 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Me7wE-0004CY-OQ for qemu-devel@nongnu.org; Thu, 20 Aug 2009 09:44:22 -0400 Date: Thu, 20 Aug 2009 10:44:11 -0300 From: Luiz Capitulino Message-ID: <20090820104411.313614ef@doriath> In-Reply-To: <4A8D0B3C.5040404@gnu.org> References: <1250723280-3509-1-git-send-email-lcapitulino@redhat.com> <1250723280-3509-3-git-send-email-lcapitulino@redhat.com> <4A8D0B3C.5040404@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 02/29] Introduce QInt List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com On Thu, 20 Aug 2009 10:37:16 +0200 Paolo Bonzini wrote: > On 08/20/2009 01:07 AM, Luiz Capitulino wrote: > > QInt is a high-level data type that can be used to store integers > > and perform type-safe conversions. > > > > The following functions are available: > > > > - qint_from_int() Create a new QInt from an int > > - qint_from_int64() Create a new QInt from an int64_t > > - qint_to_int() Export QInt to int > > - qint_to_uint64() Export QInt to uint64_t > > - qint_to_uint32() Export QInt to uint32_t > > > > Signed-off-by: Luiz Capitulino > > --- > > Makefile | 1 + > > qint.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > qint.h | 20 +++++++++++++ > > I don't see the need for a separate header file since 99.99% of the > QObject clients would include all the .h files; also, most function > could be inline in qint.h (or qobject.h) given that struct QInt is not > opaque. We could have them in qemu-common.h or create a qemu-objects.h, but I would dislike merging everything in only one header file: different things in different header files is good practice. With regard to inline you are right, but I avoided it as there's always a debate on what should be inlined and what shouldn't, I really don't want to get into this. > I also noticed this from 01/29 only now: > > +#define QType_HEAD \ > + QObject base; > > remove the trailing semicolon to ease automatic indentation in editors. OK