From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Me89a-0002FK-3Z
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 09:58:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Me89V-0002CU-Ko
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 09:58:09 -0400
Received: from [199.232.76.173] (port=49322 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Me89V-0002CM-5Z
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 09:58:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9757)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1Me89U-0000VS-Ki
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 09:58:04 -0400
Date: Thu, 20 Aug 2009 10:57:56 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20090820105756.1bd958c8@doriath>
In-Reply-To: <4A8D0202.7020803@redhat.com>
References: <1250723280-3509-1-git-send-email-lcapitulino@redhat.com>
	<1250723280-3509-5-git-send-email-lcapitulino@redhat.com>
	<4A8D0202.7020803@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 04/29] Introduce QDict
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, 20 Aug 2009 10:57:54 +0300
Avi Kivity <avi@redhat.com> wrote:

> On 08/20/2009 02:07 AM, Luiz Capitulino wrote:
> > QDict is a high-level dictionary data type that can be used to store a
> > collection of QObjects. A unique key is associated with only one
> > QObject.
> >
> > The following functions are available:
> >
> > - qdict_new()    Create a new dictionary
> > - qdict_add()    Add a new 'key:object' pair
> >    
> 
> qdict_put() is both symmetrical with qdict_get(), and also conveys the 
> fact that you can replace an existing key/value.

 Would it be useful in the current Monitor code? If so, how?

> > +/**
> > + * qdict_add_qint(): Add a new QInt into the dictionary
> > + *
> > + * Add the pair 'key:qint' into qdict. Does nothing if 'key' already
> > + * exist.
> > + *
> > + * NOTE: this function 'steals' a reference to 'qi'
> > + */
> > +void qdict_add_qint(QDict *qdict, const char *key, QInt *qi)
> > +{
> > +    qdict_add(qdict, key, QOBJECT(qi));
> > +}
> >    
> 
> I think these wrappers are superfluous, they don't really add much value.

 They exist to avoid always typing QOBJECT(), but a better way
would be:

#define qdict_add_qtype(qdict, key, qtype) \
	qdict_add(qdict, key, QOBJECT(qtype))

 I'll do the change.

> > +/**
> > + * qdict_get_int(): Get an int value mapped by 'key'
> > + *
> > + * This function assumes that 'key' exists and it stores a
> > + * QInt object.
> > + */
> > +int qdict_get_int(const QDict *qdict, const char *key)
> > +{
> > +    QObject *obj = qdict_get_obj(qdict, key, QTYPE_QINT);
> > +    return qint_to_int(qobject_to_qint(obj));
> > +}
> >    
> 
> This assumption does not hold if the dict came from a user.

 Then the user has to know what he or she is doing. :)

 The problem with high-level functions that receive a QObject
but return a plain int is: what do you return if QObject is
not an QInt?

 With QString is possible to return NULL, as you are returning
a pointer. But with ints the only solution I found was to
not accept this.

 Note that there is no problem when you are converting
between high-level types, like QObject to Qint.