From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Me8UY-0007af-Tq
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 10:19:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Me8UT-0007KR-7f
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 10:19:49 -0400
Received: from [199.232.76.173] (port=41667 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Me8UT-0007Jt-2h
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 10:19:45 -0400
Date: Thu, 20 Aug 2009 11:19:33 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20090820111933.74921045@doriath>
In-Reply-To: <4A8D0C34.2000600@gnu.org>
References: <1250723280-3509-1-git-send-email-lcapitulino@redhat.com>
	<1250723280-3509-4-git-send-email-lcapitulino@redhat.com>
	<4A8D0C34.2000600@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 03/29] Introduce QString
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com

On Thu, 20 Aug 2009 10:41:24 +0200
Paolo Bonzini <bonzini@gnu.org> wrote:

> On 08/20/2009 01:07 AM, Luiz Capitulino wrote:
> > QString is a high-level data type that can be used to store C
> > strings.
> >
> > The following functions are available:
> >
> > - qstring_from_str() Create a new QString from a C string
> > - qstring_get_str()  Return a pointer to the stored string
> >
> > Note that qstring_get_str() is too low-level for a data type like
> > this, but it's interesting for quick read-only accesses.
> 
> Same comments as for qint.h.
> 
> Maybe add qstring_dup_str, doing strdup(qstring_get_str(x))?

 This is not needed by current code, I'm avoiding adding code
that won't be used.