From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MgeMZ-0003nD-QP
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 08:46:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MgeMR-0003lT-Pk
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 08:45:56 -0400
Received: from [199.232.76.173] (port=53783 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MgeMQ-0003lG-DH
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 08:45:50 -0400
Received: from mail.gmx.net ([213.165.64.20]:36065)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <Reimar.Doeffinger@gmx.de>) id 1MgeMP-000453-QW
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 08:45:50 -0400
Date: Thu, 27 Aug 2009 14:45:46 +0200
From: Reimar =?iso-8859-1?Q?D=F6ffinger?= <Reimar.Doeffinger@gmx.de>
Subject: Re: [Qemu-devel] [PATCH] Remove typedef for bool from eepro100.c
Message-ID: <20090827124546.GA5912@1und1.de>
References: <1251376284-22426-1-git-send-email-amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1251376284-22426-1-git-send-email-amit.shah@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, Aug 27, 2009 at 06:01:24PM +0530, Amit Shah wrote:
> eepro100.c shouldn't have the need to do this in its local header file.
> 
> And I recently started getting this:
> 
> $ make -j3
> ...
>   CC    x86_64-softmmu/eepro100.o
> /home/amit/src/qemu/hw/eepro100.c:112: error: two or more data types
> in declaration specifiers
> /home/amit/src/qemu/hw/eepro100.c:112: warning: useless type name in
> empty declaration
> make[1]: *** [eepro100.o] Error 1
> 
> so just remove the typedef and include <stdbool.h> instead.
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  hw/eepro100.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/eepro100.c b/hw/eepro100.c
> index 8988b3f..0634f8c 100644
> --- a/hw/eepro100.c
> +++ b/hw/eepro100.c
> @@ -38,6 +38,7 @@
>  #endif
>  
>  #include <stddef.h>             /* offsetof */
> +#include <stdbool.h>
>  #include "hw.h"
>  #include "pci.h"
>  #include "net.h"
> @@ -109,8 +110,6 @@
>  #define INT_MASK        0x0100
>  #define DRVR_INT        0x0200  /* Driver generated interrupt. */
>  
> -typedef unsigned char bool;
> -

I doubt it matters much, but
1) stdbool bool is probably 4 bytes, not just 1 like char
2) all assignments to bool variable are converted to 0/1 which could
make a speed difference (not here since the code actually does that
explicitly).
3) is stdbool.h available everywhere where qemu is supposed to compile?

I suggest to just get rid of bool in this file, it is only used in 5
places, i.e. change
>        bool bit_el = ((command & 0x8000) != 0);
to
>        int bit_el = command & 0x8000;