From: "Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove typedef for bool from eepro100.c
Date: Thu, 27 Aug 2009 16:42:14 +0200 [thread overview]
Message-ID: <20090827144214.GA3803@1und1.de> (raw)
In-Reply-To: <761ea48b0908270700i32fbaab9kb23d3cd2bfd09ebe@mail.gmail.com>
On Thu, Aug 27, 2009 at 04:00:17PM +0200, Laurent Desnogues wrote:
> On Thu, Aug 27, 2009 at 2:45 PM, Reimar
> Döffinger<Reimar.Doeffinger@gmx.de> wrote:
> > 1) stdbool bool is probably 4 bytes, not just 1 like char
>
> It's one byte on my gcc 4.4.0.
>
> > I suggest to just get rid of bool in this file, it is only used in 5
> > places, i.e. change
> >> bool bit_el = ((command & 0x8000) != 0);
> > to
> >> int bit_el = command & 0x8000;
>
> This is dangerous if you start using bit_el in integer expressions
> by accident (for instance using & or |).
Programming errors are dangerous in general. I don't see much of a point
of cluttering the code with not really effective ways to hide their
effects (unless you wanted to suggest using "bool bit_el = command & 0x8000;",
I see that bool is already used in some places in qemu and performance
doesn't matter here so it indeed shouldn't be a problem).
next prev parent reply other threads:[~2009-08-27 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 12:31 [Qemu-devel] [PATCH] Remove typedef for bool from eepro100.c Amit Shah
2009-08-27 12:45 ` Reimar Döffinger
2009-08-27 14:00 ` Laurent Desnogues
2009-08-27 14:42 ` Reimar Döffinger [this message]
2009-08-27 14:59 ` Jamie Lokier
2009-08-27 16:25 ` Stefan Weil
2009-08-27 16:43 ` Reimar Döffinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090827144214.GA3803@1und1.de \
--to=reimar.doeffinger@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).