From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mh1PJ-0000Zs-RH for qemu-devel@nongnu.org; Fri, 28 Aug 2009 09:22:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mh1PF-0000VH-3b for qemu-devel@nongnu.org; Fri, 28 Aug 2009 09:22:21 -0400 Received: from [199.232.76.173] (port=36235 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh1PE-0000V1-TJ for qemu-devel@nongnu.org; Fri, 28 Aug 2009 09:22:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36149) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mh1PE-0001rf-Cf for qemu-devel@nongnu.org; Fri, 28 Aug 2009 09:22:16 -0400 Date: Fri, 28 Aug 2009 10:22:02 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH v2 00/29] QMonitor Message-ID: <20090828102202.2ef59eee@doriath> In-Reply-To: <20090828114334.GA3107@snarc.org> References: <1251306352-31316-1-git-send-email-lcapitulino@redhat.com> <20090828114334.GA3107@snarc.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent Hanquez Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com On Fri, 28 Aug 2009 12:43:35 +0100 Vincent Hanquez wrote: > On Wed, Aug 26, 2009 at 02:05:23PM -0300, Luiz Capitulino wrote: > > Hi there, > > > > This new version of the QMonitor series has more simplifications, > > renames and improvements. > > > > Most changes are because of simplifications on QInt, please review > > carefully its implementation and usage. > > > > Changelog, description and diffstat follows. > > Hi Luiz, > > This is a quite nice serie of patches ! just a single question with the > direction of this refactoring... > > Are you going to also wrap the monitor functions return values into the Q* types > as well ? that would make the monitor transport (whatever it is) completely > separated from the monitor functions and quite nice from a modularity PoV. Yes, that's the goal. All data that monitor functions print today will be returned to the monitor as QObjects, then the monitor will decide to print them in a user format or emit them as a machine protocol.