From: Riku Voipio <riku.voipio@iki.fi>
To: malc <av1474@comtv.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, hch@lst.de
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux native AIO support
Date: Fri, 28 Aug 2009 15:07:33 +0300 [thread overview]
Message-ID: <20090828120733.GA6942@kos.to> (raw)
In-Reply-To: <Pine.LNX.4.64.0908281437330.5472@linmac.oyster.ru>
On Fri, Aug 28, 2009 at 02:38:57PM +0400, malc wrote:
> - } else if (s->use_aio) {
> + }
> + else if (s->use_aio) {
> +#ifdef CONFIG_LINUX_AIO
> return laio_submit(bs, s->aio_ctx, s->fd, sector_num, qiov,
> - nb_sectors, cb, opaque, type);
> + nb_sectors, cb, opaque, type);
> +#else
> + abort();
> +#endif
use_aio is only ever set in CONFIG_LINUX_AIO protected section, so the #else
section is not needed. Even if that were not the case, falling back to paio_submit()
feels like a better idea than aborting emulation.
fwiw, s->use_aio is a bad name as well, as it refers to linux aio, while the
file also supports posix aio...
next parent reply other threads:[~2009-08-28 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200908280220.n7S2JlN8027935@d03av04.boulder.ibm.com>
[not found] ` <4A979033.1030506@mail.berlios.de>
[not found] ` <Pine.LNX.4.64.0908281437330.5472@linmac.oyster.ru>
2009-08-28 12:07 ` Riku Voipio [this message]
2009-08-28 15:00 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux native AIO support Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090828120733.GA6942@kos.to \
--to=riku.voipio@iki.fi \
--cc=aliguori@us.ibm.com \
--cc=av1474@comtv.ru \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).