From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mh0F2-0004rc-6i
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 08:07:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mh0Ez-0004nS-Rw
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 08:07:39 -0400
Received: from [199.232.76.173] (port=55316 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mh0Ez-0004nB-NG
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 08:07:37 -0400
Received: from narury.org ([84.20.150.76]:41850 helo=naru.obs2.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1Mh0Ey-0004jo-Vj
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 08:07:37 -0400
Date: Fri, 28 Aug 2009 15:07:33 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20090828120733.GA6942@kos.to>
References: <200908280220.n7S2JlN8027935@d03av04.boulder.ibm.com>
	<4A979033.1030506@mail.berlios.de>
	<Pine.LNX.4.64.0908281437330.5472@linmac.oyster.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0908281437330.5472@linmac.oyster.ru>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add
	Linux native AIO support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, hch@lst.de

On Fri, Aug 28, 2009 at 02:38:57PM +0400, malc wrote:
> -        } else if (s->use_aio) {
> +        }
> +        else if (s->use_aio) {
> +#ifdef CONFIG_LINUX_AIO
>              return laio_submit(bs, s->aio_ctx, s->fd, sector_num, qiov,
> -	                       nb_sectors, cb, opaque, type);
> +                               nb_sectors, cb, opaque, type);
> +#else
> +            abort();
> +#endif

use_aio is only ever set in CONFIG_LINUX_AIO protected section, so the #else
section is not needed. Even if that were not the case, falling back to paio_submit()
feels like a better idea than aborting emulation.

fwiw, s->use_aio is a bad name as well, as it refers to linux aio, while the
file also supports posix aio...