* [Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux native AIO support [not found] ` <Pine.LNX.4.64.0908281437330.5472@linmac.oyster.ru> @ 2009-08-28 12:07 ` Riku Voipio 2009-08-28 15:00 ` Christoph Hellwig 0 siblings, 1 reply; 2+ messages in thread From: Riku Voipio @ 2009-08-28 12:07 UTC (permalink / raw) To: malc; +Cc: Anthony Liguori, qemu-devel, hch On Fri, Aug 28, 2009 at 02:38:57PM +0400, malc wrote: > - } else if (s->use_aio) { > + } > + else if (s->use_aio) { > +#ifdef CONFIG_LINUX_AIO > return laio_submit(bs, s->aio_ctx, s->fd, sector_num, qiov, > - nb_sectors, cb, opaque, type); > + nb_sectors, cb, opaque, type); > +#else > + abort(); > +#endif use_aio is only ever set in CONFIG_LINUX_AIO protected section, so the #else section is not needed. Even if that were not the case, falling back to paio_submit() feels like a better idea than aborting emulation. fwiw, s->use_aio is a bad name as well, as it refers to linux aio, while the file also supports posix aio... ^ permalink raw reply [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux native AIO support 2009-08-28 12:07 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux native AIO support Riku Voipio @ 2009-08-28 15:00 ` Christoph Hellwig 0 siblings, 0 replies; 2+ messages in thread From: Christoph Hellwig @ 2009-08-28 15:00 UTC (permalink / raw) To: Riku Voipio; +Cc: Anthony Liguori, qemu-devel, hch On Fri, Aug 28, 2009 at 03:07:33PM +0300, Riku Voipio wrote: > use_aio is only ever set in CONFIG_LINUX_AIO protected section, so the #else > section is not needed. Even if that were not the case, falling back to paio_submit() > feels like a better idea than aborting emulation. > > fwiw, s->use_aio is a bad name as well, as it refers to linux aio, while the > file also supports posix aio... Yes. it was more of a quick hack. I just wanted to get a working patch out ASAP as I expect a long discussion about how to correctly set the flag to use and other bikesheds. I can send a version that just stores the bdrv_ flags in the raw state and we can check that. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-28 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200908280220.n7S2JlN8027935@d03av04.boulder.ibm.com>
[not found] ` <4A979033.1030506@mail.berlios.de>
[not found] ` <Pine.LNX.4.64.0908281437330.5472@linmac.oyster.ru>
2009-08-28 12:07 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux native AIO support Riku Voipio
2009-08-28 15:00 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).