From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mi878-0002Ka-Ha
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:44:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mi873-0002HL-Fe
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:44:09 -0400
Received: from [199.232.76.173] (port=49306 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mi873-0002H8-6D
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:44:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6734)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1Mi872-0000qb-OD
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 10:44:05 -0400
Date: Mon, 31 Aug 2009 11:43:54 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 26/29] Introduce QInt unit-tests
Message-ID: <20090831114354.002909d5@doriath>
In-Reply-To: <4A9B8209.1010900@redhat.com>
References: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com>
	<1251484052-3939-27-git-send-email-lcapitulino@redhat.com>
	<4A9B8209.1010900@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com

On Mon, 31 Aug 2009 09:55:53 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Luiz Capitulino schrieb:
> > This suite contains tests to assure that QInt API works as expected.
> > 
> > To execute it you should have check installed and build QEMU with
> > check support enabled (--enable-check-utests) and then run:
> > 
> > $ ./check-qint
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  Makefile     |    2 +
> >  check-qint.c |  110 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  configure    |    2 +-
> >  3 files changed, 113 insertions(+), 1 deletions(-)
> >  create mode 100644 check-qint.c
> 
> Shouldn't these tests better go in some subdirectory like tests/qobjects?

 I've tried to have them in tests/ but was unable to get them
building.

 As I was spending much time on this I gave up.

> > diff --git a/Makefile b/Makefile
> > index 983fe39..d08df6c 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -181,6 +181,8 @@ qemu-io$(EXESUF):  qemu-io.o qemu-tool.o cmd.o $(block-obj-y)
> >  qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
> >  	$(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@,"  GEN   $@")
> >  
> > +check-qint: check-qint.o qint.o qemu-malloc.o
> > +
> >  clean:
> >  # avoid old build problems by removing potentially incorrect old files
> >  	rm -f config.mak config.h op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
> > diff --git a/check-qint.c b/check-qint.c
> > new file mode 100644
> > index 0000000..ae5d22f
> > --- /dev/null
> > +++ b/check-qint.c
> > @@ -0,0 +1,110 @@
> > +/*
> > + * QInt unit-tests.
> > + *
> > + * Copyright (C) 2009 Red Hat Inc.
> > + *
> > + * Authors:
> > + *  Luiz Capitulino <lcapitulino@redhat.com>
> > + */
> 
> No license?

 This will sound silly, but they are so simple that I didn't
mind adding the license text there.

 Will do once they are merged or if a respin is needed.