* [Qemu-devel] [PATCH] configure: fix Linux AIO detection
@ 2009-08-31 16:18 Luiz Capitulino
2009-08-31 16:28 ` [Qemu-devel] " Juan Quintela
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Capitulino @ 2009-08-31 16:18 UTC (permalink / raw)
To: qemu-devel; +Cc: quintela
We should set $linux_aio to 'no' if detection failed, otherwise
its contents will be empty, which is a bug as we test for 'yes'
or 'no'.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
diff --git a/configure b/configure
index b805f10..4c60c4d 100755
--- a/configure
+++ b/configure
@@ -1327,6 +1327,7 @@ EOF
if test "$linux_aio" = "yes" ; then
feature_not_found "linux AIO"
fi
+ linux_aio=no
fi
fi
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [PATCH] configure: fix Linux AIO detection
2009-08-31 16:18 [Qemu-devel] [PATCH] configure: fix Linux AIO detection Luiz Capitulino
@ 2009-08-31 16:28 ` Juan Quintela
0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2009-08-31 16:28 UTC (permalink / raw)
To: Luiz Capitulino; +Cc: qemu-devel
Luiz Capitulino <lcapitulino@redhat.com> wrote:
> We should set $linux_aio to 'no' if detection failed, otherwise
> its contents will be empty, which is a bug as we test for 'yes'
> or 'no'.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
acked-by: Juan Quintela <quintela@redhat.com>
Good catch.
> diff --git a/configure b/configure
> index b805f10..4c60c4d 100755
> --- a/configure
> +++ b/configure
> @@ -1327,6 +1327,7 @@ EOF
> if test "$linux_aio" = "yes" ; then
> feature_not_found "linux AIO"
> fi
> + linux_aio=no
> fi
> fi
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-31 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-31 16:18 [Qemu-devel] [PATCH] configure: fix Linux AIO detection Luiz Capitulino
2009-08-31 16:28 ` [Qemu-devel] " Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).