From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MiUJ5-0001Ct-VE for qemu-devel@nongnu.org; Tue, 01 Sep 2009 10:26:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MiUJ1-0001AS-9u for qemu-devel@nongnu.org; Tue, 01 Sep 2009 10:25:59 -0400 Received: from [199.232.76.173] (port=42434 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MiUJ1-0001AP-42 for qemu-devel@nongnu.org; Tue, 01 Sep 2009 10:25:55 -0400 Received: from verein.lst.de ([213.95.11.210]:48018) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MiUJ0-0006aw-Iz for qemu-devel@nongnu.org; Tue, 01 Sep 2009 10:25:54 -0400 Date: Tue, 1 Sep 2009 16:25:51 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 3/4] block: add bdrv_aio_flush operation Message-ID: <20090901142551.GA17737@lst.de> References: <20090831201627.GA4811@lst.de> <20090831201730.GC4874@lst.de> <4A9CF642.5070904@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A9CF642.5070904@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Christoph Hellwig , qemu-devel@nongnu.org On Tue, Sep 01, 2009 at 01:24:02PM +0300, Avi Kivity wrote: > Doesn't aio_flush() need to wait for all previously issued requests to > complete? > > We can require callers to do that, but it seems quite a burden. The guest does it for us when using ide/scsi/virtio, and I don't think we want to grow other users. It's worth documenting, though. > Patch has some tabs. sorry, of course ;-) Writing code in the weird qemu style just takes me three times as long as readable code, sorry. I'll fix it.