From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MiuyH-0007hh-G1
	for qemu-devel@nongnu.org; Wed, 02 Sep 2009 14:54:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MiuyF-0007hO-U2
	for qemu-devel@nongnu.org; Wed, 02 Sep 2009 14:54:17 -0400
Received: from [199.232.76.173] (port=42750 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MiuyF-0007hC-KZ
	for qemu-devel@nongnu.org; Wed, 02 Sep 2009 14:54:15 -0400
Received: from narury.org ([84.20.150.76]:40185)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1MiuyF-0004b5-1m
	for qemu-devel@nongnu.org; Wed, 02 Sep 2009 14:54:15 -0400
Date: Wed, 2 Sep 2009 21:54:10 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH 2/2] Build *-user targets as PIE
Message-ID: <20090902185410.GA23405@kos.to>
References: <1251904883-13706-1-git-send-email-kirill@shutemov.name>
	<1251904883-13706-2-git-send-email-kirill@shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1251904883-13706-2-git-send-email-kirill@shutemov.name>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: qemu-devel@nongnu.org

On Wed, Sep 02, 2009 at 06:21:23PM +0300, Kirill A. Shutemov wrote:
> +if test "$target_user_only" = "yes" -a "$static" = "no" ; then
> +  cflags="-fpie $cflags"
> +  ldflags="-pie $ldflags"
> +fi

Do we really need to hadcode this in? we have --extra-cflags and
--extra-ldflags for setting non-typical flags. Other than that,
looks like a nice cleanup.