From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjKMQ-0004RX-Mp for qemu-devel@nongnu.org; Thu, 03 Sep 2009 18:00:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjKMM-0004Mb-3C for qemu-devel@nongnu.org; Thu, 03 Sep 2009 18:00:54 -0400 Received: from [199.232.76.173] (port=45554 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjKML-0004MY-U7 for qemu-devel@nongnu.org; Thu, 03 Sep 2009 18:00:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1279) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjKML-0005Lp-AX for qemu-devel@nongnu.org; Thu, 03 Sep 2009 18:00:49 -0400 Date: Thu, 3 Sep 2009 19:00:40 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH v3 00/29] QMonitor Message-ID: <20090903190040.169e4dbe@doriath> In-Reply-To: <1252012012.3084.143.camel@blaa> References: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com> <1252012012.3084.143.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com On Thu, 03 Sep 2009 22:06:52 +0100 Mark McLoughlin wrote: > On Fri, 2009-08-28 at 15:27 -0300, Luiz Capitulino wrote: > > Basically, this series introduces high-level data types (QInt, QString, > > QDict) and port all Monitor command handlers to use them to receive > > arguments. > > Very nice, carefully prepared series. Well done. > > It all looks good to me. I even went through each of the command > conversions to verify that the parameter names in the implementation > matched the names in the format and that optional parameters are handled > correctly etc. I couldn't spot a single issue. Wow, thanks a lot Mark. > > Acked-by: Mark McLoughlin > > Cheers, > Mark. >