From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MjdTd-0000oD-Qi
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 14:25:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MjdTY-0000dt-Fs
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 14:25:36 -0400
Received: from [199.232.76.173] (port=46017 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MjdTY-0000dk-Cj
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 14:25:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23218)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1MjdTX-0004MB-UP
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 14:25:32 -0400
Date: Fri, 4 Sep 2009 15:25:20 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] Fix compilation of check-qint.c by
	using a long long integer constant
Message-ID: <20090904152520.0c6072fb@doriath>
In-Reply-To: <AA5A8199-4F35-4F7F-9B84-74869EC2A25D@irisa.fr>
References: <1252084198-15375-1-git-send-email-Pierre.Riteau@irisa.fr>
	<20090904172935.GA4163@1und1.de>
	<AA5A8199-4F35-4F7F-9B84-74869EC2A25D@irisa.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pierre Riteau <Pierre.Riteau@irisa.fr>
Cc: qemu-devel@nongnu.org, Reimar =?UTF-8?B?RMO2ZmZpbmdlcg==?= <Reimar.Doeffinger@gmx.de>

On Fri, 4 Sep 2009 19:56:30 +0200
Pierre Riteau <Pierre.Riteau@irisa.fr> wrote:

>=20
> On 4 sept. 09, at 19:29, Reimar D=C3=B6ffinger wrote:
>=20
> > On Fri, Sep 04, 2009 at 07:09:58PM +0200, Pierre Riteau wrote:
> >> Error was:
> >> check-qint.c:46: error: integer constant is too large for 'long' type
> >> ---
> >> check-qint.c |    2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/check-qint.c b/check-qint.c
> >> index ae5d22f..f5c054e 100644
> >> --- a/check-qint.c
> >> +++ b/check-qint.c
> >> @@ -43,7 +43,7 @@ END_TEST
> >> START_TEST(qint_from_int64_test)
> >> {
> >>     QInt *qi;
> >> -    const int64_t value =3D 0xffffffffffffffff;
> >> +    const int64_t value =3D 0xffffffffffffffffLL;
> >
> > Hm, well it does not really fit in a signed long long either (so =20
> > from that
> > aspect it should be ULL).
> > Should it not be simply -1 (does qemu assume all architectures
> > use two's complement?)?
>=20
>=20
> How about INT64_MIN?

 The test is there to assure that QInt can handle
integers > 32-bits, so it's not an issue if we have
fewer bits.