From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MjbqP-0008RA-Mo
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 12:41:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MjbqL-0008MS-0R
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 12:41:01 -0400
Received: from [199.232.76.173] (port=48554 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MjbqK-0008M9-Nd
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 12:40:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51109)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1MjbqJ-0002zW-Ld
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 12:40:56 -0400
Date: Fri, 4 Sep 2009 22:10:30 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-console: Have a static instance of
	virtconsole
Message-ID: <20090904164030.GA31240@amit-x200.redhat.com>
References: <1252055670-26958-1-git-send-email-amit.shah@redhat.com>
	<f43fc5580909040926v29e7f6c1k68c8accd7dd431f@mail.gmail.com>
	<20090904163306.GA31086@amit-x200.redhat.com>
	<f43fc5580909040937o64fba67fy13fc21473a5cec8@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f43fc5580909040937o64fba67fy13fc21473a5cec8@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On (Fri) Sep 04 2009 [19:37:25], Blue Swirl wrote:
> On Fri, Sep 4, 2009 at 7:33 PM, Amit Shah<amit.shah@redhat.com> wrote:
> > On (Fri) Sep 04 2009 [19:26:27], Blue Swirl wrote:
> >> On Fri, Sep 4, 2009 at 12:14 PM, Amit Shah<amit.shah@redhat.com> wrote:
> >> > Currently the VirtIOConsole struct is allocated from the call
> >> > to virtio_common_init, also doing an UP_CAST implicitly.
> >> >
> >> > The new multiport functionality will need a few arrays and
> >> > it's easier to move to the new VMState infrastructure by
> >> > keeping it all within one struct.
> >>
> >> > +VirtIOConsole virtconsole;
> >>
> >> IMHO this is going to wrong direction. What kind of code would need a
> >> static instance?
> >
> > Adding multiple ports to the console device, we'll have to store an
> > array of ports here as well as config space. Both of these are
> > device-specific.
> 
> There could be a master device which managed all ports.

There's only one instance of a virtio device created, and this device
hosts multiple ports. And VirIOConsole is the master structure.

Or did I miss what it is you're saying?

		Amit