[Qemu-devel] Re: [PATCH] virtio-console: Have a static instance of virtconsole

[Amit Shah <amit.shah@redhat.com>]

On (Fri) Sep 04 2009 [19:36:33], Juan Quintela wrote:
> >> >
> >> > There's only one instance of a virtio device created, and this device
> >> > hosts multiple ports. And VirIOConsole is the master structure.
> >> 
> >> But instead of this, you should have a separate structure for the
> >> master one, if that way you can avoid the static instance.
> >
> > The problem with that is that the config space and the ports array have
> > to be made static anyway (because they get used at command-line parsing
> > time, before the virtio-console init function is called). So there's no
> > net gain for doing it that way and we're just keeping things outside of
> > the struct. And that doesn't fit well with the new proposed VMState
> > handlers.
> 
> I haven't looked at that, but qdev should help here.
> There has to be a way to create multiple devices from the command line,
> or qdev is doomed :)

We don't want multiple devices; just one virtio-console device with
several ports.

> What I haven't looked is at what part of how virt-console share the
> ports.

Share the ports in what sense?

		Amit