From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MjcmG-0005L3-9D
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 13:40:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MjcmB-0005ES-AF
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 13:40:47 -0400
Received: from [199.232.76.173] (port=57554 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MjcmB-0005EJ-3L
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 13:40:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5790)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1MjcmA-0002Sa-Eo
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 13:40:42 -0400
Date: Fri, 4 Sep 2009 23:10:06 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20090904174006.GA32444@amit-x200.redhat.com>
References: <1252055670-26958-1-git-send-email-amit.shah@redhat.com>
	<f43fc5580909040926v29e7f6c1k68c8accd7dd431f@mail.gmail.com>
	<20090904163306.GA31086@amit-x200.redhat.com>
	<f43fc5580909040937o64fba67fy13fc21473a5cec8@mail.gmail.com>
	<20090904164030.GA31240@amit-x200.redhat.com>
	<f43fc5580909040945i47b81b11raba9cf8e9951a148@mail.gmail.com>
	<20090904165144.GA31352@amit-x200.redhat.com>
	<m3y6ouy5lq.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3y6ouy5lq.fsf@neno.mitica>
Subject: [Qemu-devel] Re: [PATCH] virtio-console: Have a static instance of
	virtconsole
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On (Fri) Sep 04 2009 [19:36:33], Juan Quintela wrote:
> >> >
> >> > There's only one instance of a virtio device created, and this device
> >> > hosts multiple ports. And VirIOConsole is the master structure.
> >> 
> >> But instead of this, you should have a separate structure for the
> >> master one, if that way you can avoid the static instance.
> >
> > The problem with that is that the config space and the ports array have
> > to be made static anyway (because they get used at command-line parsing
> > time, before the virtio-console init function is called). So there's no
> > net gain for doing it that way and we're just keeping things outside of
> > the struct. And that doesn't fit well with the new proposed VMState
> > handlers.
> 
> I haven't looked at that, but qdev should help here.
> There has to be a way to create multiple devices from the command line,
> or qdev is doomed :)

We don't want multiple devices; just one virtio-console device with
several ports.

> What I haven't looked is at what part of how virt-console share the
> ports.

Share the ports in what sense?

		Amit