From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MkkMZ-00059E-3y for qemu-devel@nongnu.org; Mon, 07 Sep 2009 15:58:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MkkMU-00056J-6c for qemu-devel@nongnu.org; Mon, 07 Sep 2009 15:58:54 -0400 Received: from [199.232.76.173] (port=56157 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MkkMU-000567-3C for qemu-devel@nongnu.org; Mon, 07 Sep 2009 15:58:50 -0400 Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:62018) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MkkMO-0001uq-QM for qemu-devel@nongnu.org; Mon, 07 Sep 2009 15:58:49 -0400 Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090907195658.SGAL6742.mtaout01-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com> for ; Mon, 7 Sep 2009 20:56:58 +0100 Received: from miranda.arrow ([213.107.24.213]) by aamtaout03-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090907195658.GMLD2093.aamtaout03-winn.ispmail.ntl.com@miranda.arrow> for ; Mon, 7 Sep 2009 20:56:58 +0100 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1MkkLx-0001IH-CD for qemu-devel@nongnu.org; Mon, 07 Sep 2009 20:58:17 +0100 Date: Mon, 7 Sep 2009 20:58:17 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] Support NEC PC-98x1 on QEMU Message-ID: <20090907195817.GA4837@miranda.arrow> References: <200909071740.AA00081@YOUR-BD18D6DD63.m1.interq.or.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200909071740.AA00081@YOUR-BD18D6DD63.m1.interq.or.jp> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Takeda-san, > This is the patch to support NEC PC-98x1 on QEMU. Ooh, awesome! :) Some hopefully useful feedback, though... There's no need to add this as a whole new architecture, although perhaps the use of TARGET_PC98 was only meant to be temporary... As the patch isn't against the latest code in Git, I suppose it's not intended for inclusion just yet... Still, it'd be nice to see it cleaned up slightly, and applied! :) AFAICT, the only PC98-specific behaviour in existing source files relates to handling of: * DMA * i82078 floppy controller * i8259 interrupt controler * A20 gate The only truly CPU-specific feature that I can see is the A20 gate handling. While I don't understand why (or whether) that particular change is needed, it could certainly be done without any #ifdefs. For the other changes, I expect that it needs to be made clear that they really are PC98-specific, and that they are not just workarounds. BTW, I think most subscribers to this list (and particularly the maintainers) will be more likely to look at patches if they included inline, or attached as text/plain (with the -N flag to include new files in your patch). Zip format can be a slight disincentive for review by those with no special interest in the patch in question... Looks like great work, though! Cheers, -- Stuart Brady