From: Luiz Capitulino <lcapitulino@redhat.com>
To: Pierre Riteau <Pierre.Riteau@irisa.fr>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix and improve qint_from_int64_test
Date: Wed, 9 Sep 2009 10:41:46 -0300 [thread overview]
Message-ID: <20090909104146.4756309f@doriath> (raw)
In-Reply-To: <1252403617-30464-1-git-send-email-Pierre.Riteau@irisa.fr>
On Tue, 8 Sep 2009 11:53:37 +0200
Pierre Riteau <Pierre.Riteau@irisa.fr> wrote:
> Use a long long integer constant to fix a compilation error (integer
> constant is too large for 'long' type).
>
> Use a better value for testing, as -1 makes the test pass even if
> qi->value is of type uint32_t, float or double. This was suggested by
> Reimar Döffinger <Reimar.Doeffinger@gmx.de>.
>
> Also, make the test fail when qi->value is of type double or float by
> casting qi->value to int64_t, to avoid value being promoted to the type
> of qi->value.
>
> Signed-off-by: Pierre Riteau <Pierre.Riteau@irisa.fr>
Seems good to me.
Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
prev parent reply other threads:[~2009-09-09 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 9:53 [Qemu-devel] [PATCH] Fix and improve qint_from_int64_test Pierre Riteau
2009-09-09 13:41 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909104146.4756309f@doriath \
--to=lcapitulino@redhat.com \
--cc=Pierre.Riteau@irisa.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).