From: Glauber Costa <glommer@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 733318e] don't call cpu_sychronize_state from reset handlers
Date: Thu, 10 Sep 2009 09:29:42 -0300 [thread overview]
Message-ID: <20090910122942.GC6565@mothafucka.localdomain> (raw)
In-Reply-To: <4AA8E684.7060500@redhat.com>
On Thu, Sep 10, 2009 at 02:44:04PM +0300, Avi Kivity wrote:
> On 09/10/2009 01:37 AM, Anthony Liguori wrote:
>> From: Glauber Costa<glommer@redhat.com>
>>
>> Doing this will make the vcpu ioctl be issued from the I/O thread, instead
>> of cpu thread. The correct behaviour is to call it from within the cpu thread,
>> as soon as we are ready to go.
>>
>>
>
> This commit, when merged into qemu-kvm, breaks reboot and system_reset.
> I haven't checked upstream qemu (probably needs iothread enabled to have
> an effect).
Yes, unfortunately. I told anthony yesterday to drop it, as I have noticed it
myself. this relation is much more subtle, and I'll have to take a look at a
better way to solve the problem
next prev parent reply other threads:[~2009-09-10 12:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200909092236.n89MaDVc020267@d01av01.pok.ibm.com>
2009-09-10 10:16 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 733318e] don't call cpu_sychronize_state from reset handlers Gerd Hoffmann
2009-09-10 11:44 ` Avi Kivity
2009-09-10 12:29 ` Glauber Costa [this message]
2009-09-11 11:15 ` [Qemu-devel] " Jan Kiszka
2009-09-11 11:43 ` Glauber Costa
2009-09-11 11:52 ` Jan Kiszka
2009-09-11 12:06 ` Glauber Costa
2009-09-11 12:28 ` Jan Kiszka
2009-09-11 14:28 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910122942.GC6565@mothafucka.localdomain \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).