From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mlimh-0001NS-Cu
	for qemu-devel@nongnu.org; Thu, 10 Sep 2009 08:29:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mlimb-0001LN-RW
	for qemu-devel@nongnu.org; Thu, 10 Sep 2009 08:29:54 -0400
Received: from [199.232.76.173] (port=35868 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mlimb-0001L7-KS
	for qemu-devel@nongnu.org; Thu, 10 Sep 2009 08:29:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11723)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1Mlima-00072M-7t
	for qemu-devel@nongnu.org; Thu, 10 Sep 2009 08:29:49 -0400
Date: Thu, 10 Sep 2009 09:29:42 -0300
From: Glauber Costa <glommer@redhat.com>
Message-ID: <20090910122942.GC6565@mothafucka.localdomain>
References: <200909092236.n89MaDVc020267@d01av01.pok.ibm.com>
	<4AA8E684.7060500@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4AA8E684.7060500@redhat.com>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 733318e] don't call
	cpu_sychronize_state from reset handlers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On Thu, Sep 10, 2009 at 02:44:04PM +0300, Avi Kivity wrote:
> On 09/10/2009 01:37 AM, Anthony Liguori wrote:
>> From: Glauber Costa<glommer@redhat.com>
>>
>> Doing this will make the vcpu ioctl be issued from the I/O thread, instead
>> of cpu thread. The correct behaviour is to call it from within the cpu thread,
>> as soon as we are ready to go.
>>
>>    
>
> This commit, when merged into qemu-kvm, breaks reboot and system_reset.   
> I haven't checked upstream qemu (probably needs iothread enabled to have  
> an effect).
Yes, unfortunately. I told anthony yesterday to drop it, as I have noticed it
myself. this relation is much more subtle, and I'll have to take a look at a
better way to solve the problem