From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mm0zI-0007oc-H4 for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:56:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mm0zF-0007n3-3O for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:56:08 -0400 Received: from [199.232.76.173] (port=39808 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mm0zE-0007my-OD for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:56:04 -0400 Received: from mx20.gnu.org ([199.232.41.8]:2771) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mm0zE-0003us-1u for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:56:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mm0zD-0003tP-8q for qemu-devel@nongnu.org; Fri, 11 Sep 2009 03:56:03 -0400 Date: Fri, 11 Sep 2009 13:25:35 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH 0/12] cpuid: cleanup and some enhancements Message-ID: <20090911075535.GF31399@amit-x200.redhat.com> References: <1252621257-26364-1-git-send-email-andre.przywara@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1252621257-26364-1-git-send-email-andre.przywara@amd.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: qemu-devel@nongnu.org On (Fri) Sep 11 2009 [00:20:45], Andre Przywara wrote: > Hi, > > the following patchset cleans up CPUID bit handling and adds some smaller > features. > The most prominent change is to move all CPUID related functions to a > separate file. About 40% of helper.c was actually CPUID related, so say > hello to cpuid.c. While at it, I fixed some formatting issues. (Patch 1-5) > Patch 6 & 7 add the CPUID feature flag names to the output of -cpu ?. > Patch 8 & 9 simplify some code. > Patch 10 allows more CPUID leafs to be propagated to guests when -cpu host > is used, this should now reflect the host CPU's cache size. > Patch 11 adds a trimming feature (similar to KVM) to QEMU/TCG. The goal > is to describe CPU models more precisely by reflecting the feature bits of > the real hardware. Features that QEMU does not support are then masked. > If we add features to QEMU, we only need to adjust it in one location. > I will send a patch fixing the CPU models later. > Patch 12 adjusts the size of the L2 cache described by leaf 4 to a more > conservative value of one megabyte. This prevents guests assuming too large > caches if they use optimized algorithms. > > Please review, comment and apply! Looks like a good series! > Thanks and Regards, > Andre. Amit