From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MnuBt-0004qK-0i
	for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:04:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MnuBn-0004jJ-Kj
	for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:04:56 -0400
Received: from [199.232.76.173] (port=54254 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MnuBn-0004j8-Du
	for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:04:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4331)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MnuBm-0007Ww-QG
	for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:04:51 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8GD4noY011381
	for <qemu-devel@nongnu.org>; Wed, 16 Sep 2009 09:04:49 -0400
Date: Wed, 16 Sep 2009 16:03:04 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090916130304.GB4795@redhat.com>
References: <20090916104620.GA4456@redhat.com> <m34or3up58.fsf@neno.mitica>
	<20090916111845.GJ23157@redhat.com>
	<m3ocpbt8j0.fsf@neno.mitica> <20090916115224.GA4628@redhat.com>
	<m3fxant7br.fsf@neno.mitica> <20090916121818.GA4710@redhat.com>
	<m37hvzt6r1.fsf@neno.mitica> <20090916123710.GB4729@redhat.com>
	<m3fxanrql9.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3fxanrql9.fsf@neno.mitica>
Subject: [Qemu-devel] Re: optional feature
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

On Wed, Sep 16, 2009 at 03:01:22PM +0200, Juan Quintela wrote:
> >> > pci config is on vmstate already, I don't see a problem here.
> >> 
> >> vmstate don't understand pci config.
> >
> > How can it save it then? What's more, how can it load it sanely? E.g.
> > when loading we must make sure that device id etc match.
> 
> We don't test it at all.

Someone has to. Existing code has it.  Removing this sanity check and
changing e.g. device id by load will be a bad thing.

-- 
MST