[Qemu-devel] [PATCH] tcg: fix size of local variables in tcg_gen_bswap64_i64

[Qemu-devel] [PATCH] tcg: fix size of local variables in tcg_gen_bswap64_i64

[Stefan Weil]

t0, t1 must be 64 bit values, not 32 bit.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 tcg/tcg-op.h |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
index f3f2f71..7cb6934 100644
--- a/tcg/tcg-op.h
+++ b/tcg/tcg-op.h
@@ -1441,9 +1441,8 @@ static inline void tcg_gen_bswap64_i64(TCGv_i64 ret, TCGv_i64 arg)
 #ifdef TCG_TARGET_HAS_bswap64_i64
     tcg_gen_op2_i64(INDEX_op_bswap64_i64, ret, arg);
 #else
-    TCGv_i32 t0, t1;
-    t0 = tcg_temp_new_i32();
-    t1 = tcg_temp_new_i32();
+    TCGv_i64 t0 = tcg_temp_new_i64();
+    TCGv_i64 t1 = tcg_temp_new_i64();
     
     tcg_gen_shli_i64(t0, arg, 56);
     
@@ -1473,8 +1472,8 @@ static inline void tcg_gen_bswap64_i64(TCGv_i64 ret, TCGv_i64 arg)
 
     tcg_gen_shri_i64(t1, arg, 56);
     tcg_gen_or_i64(ret, t0, t1);
-    tcg_temp_free_i32(t0);
-    tcg_temp_free_i32(t1);
+    tcg_temp_free_i64(t0);
+    tcg_temp_free_i64(t1);
 #endif
 }
 
-- 
1.5.6.5

Re: [Qemu-devel] [PATCH] tcg: fix size of local variables in tcg_gen_bswap64_i64

[Aurelien Jarno]

On Sat, Sep 05, 2009 at 06:54:10PM +0200, Stefan Weil wrote:
> t0, t1 must be 64 bit values, not 32 bit.
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Thanks, applied.
 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net