From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqSj1-0006m7-MH
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 10:21:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqSix-0006lt-SA
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 10:21:43 -0400
Received: from [199.232.76.173] (port=48499 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqSix-0006lq-NT
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 10:21:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54976)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1MqSiw-0006B3-Qq
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 10:21:39 -0400
Date: Wed, 23 Sep 2009 11:21:29 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] ANN: QEMU Monitor Protocol git tree
Message-ID: <20090923112129.4c3bff63@doriath>
In-Reply-To: <20090923100822.GF29269@redhat.com>
References: <20090921224430.610da97b@doriath>
	<20090923100822.GF29269@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com

On Wed, 23 Sep 2009 11:08:22 +0100
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Mon, Sep 21, 2009 at 10:44:30PM -0300, Luiz Capitulino wrote:
> >=20
> >  Hi there,
> >=20
> > While I was converting command handlers to the QObject style I realized=
 that
> > it would be very interesting to have the protocol working up front, so =
that
> > converted handlers could be tested to assure that their data types have=
 been
> > chosen correctly.
> >=20
> > More importantly, some protocol design decisions can affect handlers si=
gnatures,
> > so having at least an idea of how the protocol will look like will help=
 us to
> > stay on the right track during mass conversion.
> >=20
> > So, I have implemented a rudimentary version of the QEMU Monitor Protoc=
ol (QMP)
> > it has a command-line switch to enable the protocol.
> >=20
> > You will find it at:
> >=20
> > http://repo.or.cz/w/qemu/qmp-unstable.git
> >=20
> > The QMP directory of that tree has some documents plus a Python script =
which
> > communicates with QEMU by using the protocol and emulates a shell, alth=
ough
> > only few commands are working..
>=20
> It doesn't compile on i386
>=20
> $ make
>   CC    i386-softmmu/monitor.o
> cc1: warnings being treated as errors
> /home/berrange/src/external/qmp-unstable/monitor.c: In function =C3=A2=E2=
=82=AC=CB=9Cmonitor_json_emitter=C3=A2=E2=82=AC=E2=84=A2:
> /home/berrange/src/external/qmp-unstable/monitor.c:277: error: format =C3=
=A2=E2=82=AC=CB=9C%li=C3=A2=E2=82=AC=E2=84=A2 expects type =C3=A2=E2=82=AC=
=CB=9Clong int=C3=A2=E2=82=AC=E2=84=A2, but argument 3 has type =C3=A2=E2=
=82=AC=CB=9Cint64_t=C3=A2=E2=82=AC=E2=84=A2
> /home/berrange/src/external/qmp-unstable/monitor.c: In function =C3=A2=E2=
=82=AC=CB=9Cmonitor_print_qobject=C3=A2=E2=82=AC=E2=84=A2:
> /home/berrange/src/external/qmp-unstable/monitor.c:398: error: format =C3=
=A2=E2=82=AC=CB=9C%lu=C3=A2=E2=82=AC=E2=84=A2 expects type =C3=A2=E2=82=AC=
=CB=9Clong unsigned int=C3=A2=E2=82=AC=E2=84=A2, but argument 3 has type =
=C3=A2=E2=82=AC=CB=9Cint64_t=C3=A2=E2=82=AC=E2=84=A2
> make[1]: *** [monitor.o] Error 1

 Fixed.

 Note that I'm rebasing this tree, so that I can cherry-pick
patches easily for upstream submission.