From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, anthony@codemonkey.ws,
Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] comments on: get page size in device init
Date: Wed, 23 Sep 2009 15:58:18 +0300 [thread overview]
Message-ID: <20090923125818.GA13875@redhat.com> (raw)
> Compile msix only once
>
> Get page size in device init.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
What was the motivation for the page size change?
It seems the only user passes TARGET_PAGE_SIZE anyway,
using a constant seems clearer and probably generates
less code. No?
Did I miss this patch on qemu-devel? Generally, it's nice to have
patches posted to list to give people a chance to comment, before they
are pushed to the public tree. Right?
Finally, the 2 changes seem unrelated: why was it a good idea to bundle
them in one commit?
Thanks,
--
MST
next reply other threads:[~2009-09-23 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 12:58 Michael S. Tsirkin [this message]
2009-09-23 17:07 ` [Qemu-devel] Re: comments on: get page size in device init Blue Swirl
2009-09-23 18:02 ` Anthony Liguori
2009-09-23 18:40 ` Michael S. Tsirkin
2009-09-23 19:03 ` Blue Swirl
2009-09-23 19:13 ` Michael S. Tsirkin
2009-09-23 19:59 ` Blue Swirl
2009-09-23 19:19 ` Michael S. Tsirkin
2009-09-23 20:35 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923125818.GA13875@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).