From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqRjy-0003Pd-B4 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 09:18:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqRjr-0003GA-5f for qemu-devel@nongnu.org; Wed, 23 Sep 2009 09:18:36 -0400 Received: from [199.232.76.173] (port=58546 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqRjq-0003F1-4j for qemu-devel@nongnu.org; Wed, 23 Sep 2009 09:18:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22248) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqRjo-0006Pv-Uq for qemu-devel@nongnu.org; Wed, 23 Sep 2009 09:18:29 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8NDIPcd017159 for ; Wed, 23 Sep 2009 09:18:25 -0400 Date: Wed, 23 Sep 2009 18:47:54 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-console: Add support for multiple ports for generic guest-host communication Message-ID: <20090923131754.GB31933@amit-x200.redhat.com> References: <1253636627-12746-2-git-send-email-amit.shah@redhat.com> <1253636627-12746-3-git-send-email-amit.shah@redhat.com> <1253636627-12746-4-git-send-email-amit.shah@redhat.com> <4AB9E536.4050001@redhat.com> <20090923094340.GA27483@amit-x200.redhat.com> <4ABA0481.6090603@redhat.com> <20090923115043.GA28088@amit-x200.redhat.com> <4ABA14EF.2050703@redhat.com> <20090923124032.GA31933@amit-x200.redhat.com> <4ABA1CDB.7080209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ABA1CDB.7080209@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On (Wed) Sep 23 2009 [15:04:27], Gerd Hoffmann wrote: >>> -device virtio-console >>> Creates the portbus master. No ports (yet). >>> >>> -device vmport-console,chardev=$dev >>> Creates a port named 'org.qemu.console' and links it to $dev. >> >> OK; that's what I have now, slightly different: >> >> -device virtio-console-pci -device virtconport,port=0,chardev=$dev > > Fine as well. The exact names don't really matter, the naming for the > port drivers should be consistent though (i.e. have the same prefix for Yes. > all of them or something like that). Optional port number looks > reasonable too. Should default to auto-allocation if not specified. Once that gets decided :-) It's still not decided if we'll be optional port numbers vs assigned. >>> For backward-compatibility we'll allways have to create a vmport-console >>> at port 0, so there will never be a virtio-console without a port. That >>> is a minor bit we can fixup once the above works fine. >> >> ie -virtioconsole ? > > There are two kinds of backward compatibility ;) One is the qemu Yes, I wanted to know which one you're thinking about. > command line. The other is the ABI for old guest drivers. The later > requires a console at port 0 ... For that, there are two options: 1. If we go with a static port function -> port number mapping, this is easy (as I already have now). 2. If we go with dynamic numbers, the guest could register the hvc console only for a device that has the name 'org.qemu.console.0'. This supports multiple ports as well. >> I'd suggest we just drop that in 0.12. > > Dropping the command line switch is with me. In case someone disagrees > (libvirt folks?) it isn't hard to maintain compatibility though. It's not much effort to maintain that, but the old and new syntaxes are very different. qemu 0.11 doesn't offer the ability to support multiple virtioconsoles, but 0.12 will. So the cmd line syntax has to change for that anyway, might as well deprecate the older syntax. Amit