From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqWnd-0002Ci-TK
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 14:42:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqWnZ-0002Au-Rh
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 14:42:45 -0400
Received: from [199.232.76.173] (port=55497 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqWnZ-0002Ak-EX
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 14:42:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63384)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MqWnY-0004xV-Sj
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 14:42:41 -0400
Date: Wed, 23 Sep 2009 21:40:41 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090923184041.GA18947@redhat.com>
References: <20090923125818.GA13875@redhat.com>
	<f43fc5580909231007q7fbad3a0ydb07e8b8e30f5603@mail.gmail.com>
	<4ABA62D0.2060205@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ABA62D0.2060205@codemonkey.ws>
Subject: [Qemu-devel] Re: comments on: get page size in device init
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Wed, Sep 23, 2009 at 01:02:56PM -0500, Anthony Liguori wrote:
> Blue Swirl wrote:
>> On Wed, Sep 23, 2009 at 3:58 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>>   
>>>>     Compile msix only once
>>>>
>>>>     Get page size in device init.
>>>>
>>>>     Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>>>>       
>>> What was the motivation for the page size change?
>>>     
>>
>> "Compile msix only once"
>>
>>   
>>> It seems the only user passes TARGET_PAGE_SIZE anyway,
>>> using a constant seems clearer and probably generates
>>> less code. No?
>>>     
>>
>> Yes, but then the code would depend on TARGET_PAGE_SIZE, making it
>> impossible to compile the code only once.
>>   
>
> We could probably get away with doing
>
> #define TARGET_PAGE_SIZE target_get_page_size()
>
> And take care of a big chunk of this without passing page size  
> parameters around.


Sounds good.

> Regards,
>
> Anthony Liguori