From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqoQn-0007VZ-FD
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 09:32:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqoQk-0007VN-2u
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 09:32:21 -0400
Received: from [199.232.76.173] (port=52793 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqoQj-0007VI-OT
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 09:32:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10858)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1MqoQi-0003RV-EC
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 09:32:16 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8ODWE4X020853
	for <qemu-devel@nongnu.org>; Thu, 24 Sep 2009 09:32:15 -0400
Date: Thu, 24 Sep 2009 19:01:44 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of
	silently exiting
Message-ID: <20090924133144.GA19389@amit-x200.redhat.com>
References: <1253704471-30740-1-git-send-email-amit.shah@redhat.com>
	<8763b97588.fsf@pike.pond.sub.org>
	<20090924035908.GA4584@amit-x200.redhat.com>
	<87my4kqxl8.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87my4kqxl8.fsf@pike.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On (Thu) Sep 24 2009 [15:30:27], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > Hey Markus,
> >
> > On (Wed) Sep 23 2009 [22:53:27], Markus Armbruster wrote:
> >> Amit Shah <amit.shah@redhat.com> writes:
> >> 
> >> > If initializing a device fails, show the name of the device
> >> > and then exit
> >> 
> >> "and then exit" is misleading, as you don't add an exit.
> >
> > The 'return NULL' does that -- the calling function exits.
> > (doesn't the subject line clarify that?)
> 
> You could say "show the name of the device before exiting".

That's what the subject says! :-)

> The message as you worded it made me look for an exit where there wasn't
> one before.

I'll respin it nevertheless.

		Amit