From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqtRA-0000iB-FO
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 14:53:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqtR6-0000hE-Ue
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 14:53:04 -0400
Received: from [199.232.76.173] (port=49286 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqtR6-0000hB-SV
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 14:53:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33964)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MqtR6-0007I0-7a
	for qemu-devel@nongnu.org; Thu, 24 Sep 2009 14:53:00 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8OIqw3G009226
	for <qemu-devel@nongnu.org>; Thu, 24 Sep 2009 14:52:58 -0400
Date: Thu, 24 Sep 2009 21:51:02 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/13] convert pci bridge to qdev
Message-ID: <20090924185101.GA29419@redhat.com>
References: <1253611767-6483-1-git-send-email-kraxel@redhat.com>
	<1253611767-6483-7-git-send-email-kraxel@redhat.com>
	<20090923160200.GC18203@redhat.com>
	<87skecb3h7.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87skecb3h7.fsf@pike.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Thu, Sep 24, 2009 at 08:29:56PM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > On Tue, Sep 22, 2009 at 11:29:20AM +0200, Gerd Hoffmann wrote:
> >> @@ -890,15 +890,12 @@ PCIDevice *pci_find_device(int bus_num, int slot, int function)
> >>      return bus->devices[PCI_DEVFN(slot, function)];
> >>  }
> >>  
> >> -PCIBus *pci_bridge_init(PCIBus *bus, int devfn, uint16_t vid, uint16_t did,
> >> -                        pci_map_irq_fn map_irq, const char *name)
> >> +static int pci_bridge_initfn(PCIDevice *dev)
> >
> > pci_bridge_dev_init a better name?
> 
> There's precedence for _initfn, _init1, and _init.  I wish we'd pick one
> convention and stick to it.

The problem here is that we now have *both* pci_bridge_init and
pci_bridge_initfn.

> [...]