From: Luiz Capitulino <lcapitulino@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH+SoB] unbreak usb pass-through on linux.
Date: Fri, 25 Sep 2009 12:41:15 -0300 [thread overview]
Message-ID: <20090925124115.75696021@doriath> (raw)
In-Reply-To: <1253890528-4139-1-git-send-email-kraxel@redhat.com>
On Fri, 25 Sep 2009 16:55:28 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:
> Changes:
> * Re-add the 'dev->fd = fd;' line which the qdev patches dropped
> by mistake.
> * call qdev_init() so the newly created usb device is plugged into
> a usb port and thus actually visible to the guest.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Simple tests work for me, thanks a lot Gerd.
Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> usb-linux.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/usb-linux.c b/usb-linux.c
> index c434e4f..2b7b092 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -922,6 +922,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
>
> dev->bus_num = bus_num;
> dev->addr = addr;
> + dev->fd = fd;
>
> /* read the device description */
> dev->descr_len = read(fd, dev->descr, sizeof(dev->descr));
> @@ -979,6 +980,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
>
> hostdev_link(dev);
>
> + qdev_init(&d->qdev);
> return (USBDevice *) dev;
>
> fail:
prev parent reply other threads:[~2009-09-25 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 14:55 [Qemu-devel] [PATCH+SoB] unbreak usb pass-through on linux Gerd Hoffmann
2009-09-25 15:41 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090925124115.75696021@doriath \
--to=lcapitulino@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).