From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MrDdM-0001kN-BL
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 12:27:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MrDdG-0001gU-Qd
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 12:26:59 -0400
Received: from [199.232.76.173] (port=56089 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MrDdG-0001gR-EA
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 12:26:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60424)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1MrDdF-0004nV-47
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 12:26:53 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8PGQqO5001064
	for <qemu-devel@nongnu.org>; Fri, 25 Sep 2009 12:26:52 -0400
Date: Fri, 25 Sep 2009 13:26:44 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error &
	other fixes
Message-ID: <20090925132644.2bc8fd60@doriath>
In-Reply-To: <cover.1253843232.git.armbru@redhat.com>
References: <cover.1253843232.git.armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, 25 Sep 2009 03:53:47 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Markus Armbruster (6):
>   Fix pci_vga_init() not to ignore bus argument
>   Fix pci_add storage not to exit on bad first argument
>   Make it obvious that pci_nic_init() can't fail
>   Fix pci_add nic not to exit on bad model
>   pci_create() is now unused, remove it
>   Rename pci_create_noinit() to pci_create()

 The Right Thing :) and it (obviously) fixes the problem with
pci_add for me.

 The only nitpick is that by passing an invalid NIC on command
line would make qemu dump valid NIC models.. But not an issue,
anyway.