From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MrBpL-0005DM-Va
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 10:31:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MrBpK-0005Ca-8z
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 10:31:15 -0400
Received: from [199.232.76.173] (port=36374 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MrBpK-0005CV-3s
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 10:31:14 -0400
Received: from hall.aurel32.net ([88.191.82.174]:49985)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1MrBpJ-0002KK-JC
	for qemu-devel@nongnu.org; Fri, 25 Sep 2009 10:31:13 -0400
Date: Fri, 25 Sep 2009 16:31:10 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] unbreak usb pass-through on linux.
Message-ID: <20090925143110.GA14026@volta.aurel32.net>
References: <1253880934-25029-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1253880934-25029-1-git-send-email-kraxel@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Sep 25, 2009 at 02:15:34PM +0200, Gerd Hoffmann wrote:
> Changes:
>   * Re-add the 'dev->fd = fd;' line which the qdev patches dropped
>     by mistake.
>   * call qdev_init() so the newly created usb device is plugged into
>     a usb port and thus actually visible to the guest.
> ---
>  usb-linux.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Good work. A SoB is missing though.

> diff --git a/usb-linux.c b/usb-linux.c
> index c434e4f..2b7b092 100644
> --- a/usb-linux.c
> +++ b/usb-linux.c
> @@ -922,6 +922,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
>  
>      dev->bus_num = bus_num;
>      dev->addr = addr;
> +    dev->fd = fd;
>  
>      /* read the device description */
>      dev->descr_len = read(fd, dev->descr, sizeof(dev->descr));
> @@ -979,6 +980,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
>  
>      hostdev_link(dev);
>  
> +    qdev_init(&d->qdev);
>      return (USBDevice *) dev;
>  
>  fail:
> -- 
> 1.6.2.5
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net