[Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Aurelien Jarno]

On Fri, Sep 25, 2009 at 07:24:37PM -0000, Anthony Liguori wrote:
> From: Blue Swirl <blauwirbel@gmail.com>
> 
> This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
> 
> tcg-runtime and host-utils are needed on 32 bit host and they are not part
> of libqemu.a.
> 
> Thanks to Stefan Weil for reporting.
> 

So what is the correct fix to the original problem? All the user-linux 
targets are failing to build following commits
96e132e24ee5a693069e83b6a981693588b088c1 and
c2b023b62707f5dc73497dc03f3764f145a29785:

$ LC_ALL=C make
  LINK  i386-linux-user/qemu-i386
gcc: tcg-runtime.o: No such file or directory
gcc: host-utils.o: No such file or directory
make[1]: *** [qemu-i386] Error 1
make: *** [subdir-i386-linux-user] Error 2


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

[Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Blue Swirl]

On Fri, Sep 25, 2009 at 11:23 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Fri, Sep 25, 2009 at 07:24:37PM -0000, Anthony Liguori wrote:
>> From: Blue Swirl <blauwirbel@gmail.com>
>>
>> This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
>>
>> tcg-runtime and host-utils are needed on 32 bit host and they are not part
>> of libqemu.a.
>>
>> Thanks to Stefan Weil for reporting.
>>
>
> So what is the correct fix to the original problem? All the user-linux
> targets are failing to build following commits
> 96e132e24ee5a693069e83b6a981693588b088c1 and
> c2b023b62707f5dc73497dc03f3764f145a29785:
>
> $ LC_ALL=C make
>  LINK  i386-linux-user/qemu-i386
> gcc: tcg-runtime.o: No such file or directory
> gcc: host-utils.o: No such file or directory
> make[1]: *** [qemu-i386] Error 1
> make: *** [subdir-i386-linux-user] Error 2

I can't reproduce the problem (i386 log below). Did you run make clean?

  LINK  ppc-linux-user/qemu-ppc
  CC    i386-linux-user/main.o
  CC    i386-linux-user/syscall.o
  CC    i386-linux-user/strace.o
  CC    i386-linux-user/mmap.o
  CC    i386-linux-user/signal.o
  CC    i386-linux-user/thunk.o
  CC    i386-linux-user/elfload.o
  CC    i386-linux-user/linuxload.o
  CC    i386-linux-user/uaccess.o
  CC    i386-linux-user/gdbstub.o
  GEN   i386-linux-user/gdbstub-xml.c
  CC    i386-linux-user/gdbstub-xml.o
  CC    i386-linux-user/envlist.o
  CC    i386-linux-user/path.o
  CC    i386-linux-user/tcg-runtime.o
  CC    i386-linux-user/host-utils.o
  CC    i386-linux-user/vm86.o
  CC    i386-linux-user/cutils-user.o
  CC    i386-linux-user/cache-utils-user.o
  CC    i386-linux-user/ioport-user.o
  CC    i386-linux-user/exec.o
  CC    i386-linux-user/translate-all.o
  CC    i386-linux-user/cpu-exec.o
  CC    i386-linux-user/translate.o
  CC    i386-linux-user/tcg/tcg.o
  CC    i386-linux-user/fpu/softfloat-native.o
  CC    i386-linux-user/op_helper.o
  CC    i386-linux-user/helper.o
  CC    i386-linux-user/disas.o
  CC    i386-linux-user/i386-dis.o
  AR    i386-linux-user/libqemu.a
  LINK  i386-linux-user/qemu-i386
  CC    x86_64-linux-user/main.o

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Aurelien Jarno]

On Sat, Sep 26, 2009 at 09:44:39AM +0300, Blue Swirl wrote:
> On Fri, Sep 25, 2009 at 11:23 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > On Fri, Sep 25, 2009 at 07:24:37PM -0000, Anthony Liguori wrote:
> >> From: Blue Swirl <blauwirbel@gmail.com>
> >>
> >> This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
> >>
> >> tcg-runtime and host-utils are needed on 32 bit host and they are not part
> >> of libqemu.a.
> >>
> >> Thanks to Stefan Weil for reporting.
> >>
> >
> > So what is the correct fix to the original problem? All the user-linux
> > targets are failing to build following commits
> > 96e132e24ee5a693069e83b6a981693588b088c1 and
> > c2b023b62707f5dc73497dc03f3764f145a29785:
> >
> > $ LC_ALL=C make
> >  LINK  i386-linux-user/qemu-i386
> > gcc: tcg-runtime.o: No such file or directory
> > gcc: host-utils.o: No such file or directory
> > make[1]: *** [qemu-i386] Error 1
> > make: *** [subdir-i386-linux-user] Error 2
> 
> I can't reproduce the problem (i386 log below). Did you run make clean?
> 

Yes 'make clean' or even 'git clean -fdx' doesn't change anything, the
problem is still there.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Aurelien Jarno]

On Sat, Sep 26, 2009 at 09:25:29AM +0200, Aurelien Jarno wrote:
> On Sat, Sep 26, 2009 at 09:44:39AM +0300, Blue Swirl wrote:
> > On Fri, Sep 25, 2009 at 11:23 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > > On Fri, Sep 25, 2009 at 07:24:37PM -0000, Anthony Liguori wrote:
> > >> From: Blue Swirl <blauwirbel@gmail.com>
> > >>
> > >> This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
> > >>
> > >> tcg-runtime and host-utils are needed on 32 bit host and they are not part
> > >> of libqemu.a.
> > >>
> > >> Thanks to Stefan Weil for reporting.
> > >>
> > >
> > > So what is the correct fix to the original problem? All the user-linux
> > > targets are failing to build following commits
> > > 96e132e24ee5a693069e83b6a981693588b088c1 and
> > > c2b023b62707f5dc73497dc03f3764f145a29785:
> > >
> > > $ LC_ALL=C make
> > >  LINK  i386-linux-user/qemu-i386
> > > gcc: tcg-runtime.o: No such file or directory
> > > gcc: host-utils.o: No such file or directory
> > > make[1]: *** [qemu-i386] Error 1
> > > make: *** [subdir-i386-linux-user] Error 2
> > 
> > I can't reproduce the problem (i386 log below). Did you run make clean?
> > 
> 
> Yes 'make clean' or even 'git clean -fdx' doesn't change anything, the
> problem is still there.
> 

OTOH, using configure --disable-system workarounds the problem.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Blue Swirl]

On Sat, Sep 26, 2009 at 10:53 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Sat, Sep 26, 2009 at 09:25:29AM +0200, Aurelien Jarno wrote:
>> On Sat, Sep 26, 2009 at 09:44:39AM +0300, Blue Swirl wrote:
>> > On Fri, Sep 25, 2009 at 11:23 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
>> > > On Fri, Sep 25, 2009 at 07:24:37PM -0000, Anthony Liguori wrote:
>> > >> From: Blue Swirl <blauwirbel@gmail.com>
>> > >>
>> > >> This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
>> > >>
>> > >> tcg-runtime and host-utils are needed on 32 bit host and they are not part
>> > >> of libqemu.a.
>> > >>
>> > >> Thanks to Stefan Weil for reporting.
>> > >>
>> > >
>> > > So what is the correct fix to the original problem? All the user-linux
>> > > targets are failing to build following commits
>> > > 96e132e24ee5a693069e83b6a981693588b088c1 and
>> > > c2b023b62707f5dc73497dc03f3764f145a29785:
>> > >
>> > > $ LC_ALL=C make
>> > >  LINK  i386-linux-user/qemu-i386
>> > > gcc: tcg-runtime.o: No such file or directory
>> > > gcc: host-utils.o: No such file or directory
>> > > make[1]: *** [qemu-i386] Error 1
>> > > make: *** [subdir-i386-linux-user] Error 2
>> >
>> > I can't reproduce the problem (i386 log below). Did you run make clean?
>> >
>>
>> Yes 'make clean' or even 'git clean -fdx' doesn't change anything, the
>> problem is still there.
>>
>
> OTOH, using configure --disable-system workarounds the problem.

I've tried the following cases (both x86_64 + i386 host, x86_64 + i386 targets):
* system targets before user targets
* user targets before system targets
* just user targets

Every time tcg-runtime etc. are built correctly and final link succeeds.

The only (unrelated) problems I see are that option rom is
unnecessarily built even for user target only case and that we lost
the ability to build some user files just once for all targets at some
point.

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Aurelien Jarno]

On Sat, Sep 26, 2009 at 11:22:31AM +0300, Blue Swirl wrote:
> On Sat, Sep 26, 2009 at 10:53 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > On Sat, Sep 26, 2009 at 09:25:29AM +0200, Aurelien Jarno wrote:
> >> On Sat, Sep 26, 2009 at 09:44:39AM +0300, Blue Swirl wrote:
> >> > On Fri, Sep 25, 2009 at 11:23 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> >> > > On Fri, Sep 25, 2009 at 07:24:37PM -0000, Anthony Liguori wrote:
> >> > >> From: Blue Swirl <blauwirbel@gmail.com>
> >> > >>
> >> > >> This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
> >> > >>
> >> > >> tcg-runtime and host-utils are needed on 32 bit host and they are not part
> >> > >> of libqemu.a.
> >> > >>
> >> > >> Thanks to Stefan Weil for reporting.
> >> > >>
> >> > >
> >> > > So what is the correct fix to the original problem? All the user-linux
> >> > > targets are failing to build following commits
> >> > > 96e132e24ee5a693069e83b6a981693588b088c1 and
> >> > > c2b023b62707f5dc73497dc03f3764f145a29785:
> >> > >
> >> > > $ LC_ALL=C make
> >> > >  LINK  i386-linux-user/qemu-i386
> >> > > gcc: tcg-runtime.o: No such file or directory
> >> > > gcc: host-utils.o: No such file or directory
> >> > > make[1]: *** [qemu-i386] Error 1
> >> > > make: *** [subdir-i386-linux-user] Error 2
> >> >
> >> > I can't reproduce the problem (i386 log below). Did you run make clean?
> >> >
> >>
> >> Yes 'make clean' or even 'git clean -fdx' doesn't change anything, the
> >> problem is still there.
> >>
> >
> > OTOH, using configure --disable-system workarounds the problem.
> 
> I've tried the following cases (both x86_64 + i386 host, x86_64 + i386 targets):
> * system targets before user targets
> * user targets before system targets
> * just user targets
> 

Some people tried to reproduce the problem on IRC, and it seems the
conditions are:
- use in-tree building
- build user targets after system targets

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Blue Swirl]

On Sat, Sep 26, 2009 at 11:49 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Sat, Sep 26, 2009 at 11:22:31AM +0300, Blue Swirl wrote:
>> On Sat, Sep 26, 2009 at 10:53 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
>> > On Sat, Sep 26, 2009 at 09:25:29AM +0200, Aurelien Jarno wrote:
>> >> On Sat, Sep 26, 2009 at 09:44:39AM +0300, Blue Swirl wrote:
>> >> > On Fri, Sep 25, 2009 at 11:23 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
>> >> > > On Fri, Sep 25, 2009 at 07:24:37PM -0000, Anthony Liguori wrote:
>> >> > >> From: Blue Swirl <blauwirbel@gmail.com>
>> >> > >>
>> >> > >> This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
>> >> > >>
>> >> > >> tcg-runtime and host-utils are needed on 32 bit host and they are not part
>> >> > >> of libqemu.a.
>> >> > >>
>> >> > >> Thanks to Stefan Weil for reporting.
>> >> > >>
>> >> > >
>> >> > > So what is the correct fix to the original problem? All the user-linux
>> >> > > targets are failing to build following commits
>> >> > > 96e132e24ee5a693069e83b6a981693588b088c1 and
>> >> > > c2b023b62707f5dc73497dc03f3764f145a29785:
>> >> > >
>> >> > > $ LC_ALL=C make
>> >> > >  LINK  i386-linux-user/qemu-i386
>> >> > > gcc: tcg-runtime.o: No such file or directory
>> >> > > gcc: host-utils.o: No such file or directory
>> >> > > make[1]: *** [qemu-i386] Error 1
>> >> > > make: *** [subdir-i386-linux-user] Error 2
>> >> >
>> >> > I can't reproduce the problem (i386 log below). Did you run make clean?
>> >> >
>> >>
>> >> Yes 'make clean' or even 'git clean -fdx' doesn't change anything, the
>> >> problem is still there.
>> >>
>> >
>> > OTOH, using configure --disable-system workarounds the problem.
>>
>> I've tried the following cases (both x86_64 + i386 host, x86_64 + i386 targets):
>> * system targets before user targets
>> * user targets before system targets
>> * just user targets
>>
>
> Some people tried to reproduce the problem on IRC, and it seems the
> conditions are:
> - use in-tree building
> - build user targets after system targets

Okay, now I can reproduce this. I try to avoid in-tree building if possible.

Perhaps there should be a -user symlink hack similar to cutils.c and
cache-utils.c. It's getting a bit ugly, though.

Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3f600fa] Revert "This files are compiled in libqemu.a now"

[Aurelien Jarno]

On Sat, Sep 26, 2009 at 09:53:21AM +0200, Aurelien Jarno wrote:
> On Sat, Sep 26, 2009 at 09:25:29AM +0200, Aurelien Jarno wrote:
> > On Sat, Sep 26, 2009 at 09:44:39AM +0300, Blue Swirl wrote:
> > > On Fri, Sep 25, 2009 at 11:23 PM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > > > On Fri, Sep 25, 2009 at 07:24:37PM -0000, Anthony Liguori wrote:
> > > >> From: Blue Swirl <blauwirbel@gmail.com>
> > > >>
> > > >> This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
> > > >>
> > > >> tcg-runtime and host-utils are needed on 32 bit host and they are not part
> > > >> of libqemu.a.
> > > >>
> > > >> Thanks to Stefan Weil for reporting.
> > > >>
> > > >
> > > > So what is the correct fix to the original problem? All the user-linux
> > > > targets are failing to build following commits
> > > > 96e132e24ee5a693069e83b6a981693588b088c1 and
> > > > c2b023b62707f5dc73497dc03f3764f145a29785:
> > > >
> > > > $ LC_ALL=C make
> > > >  LINK  i386-linux-user/qemu-i386
> > > > gcc: tcg-runtime.o: No such file or directory
> > > > gcc: host-utils.o: No such file or directory
> > > > make[1]: *** [qemu-i386] Error 1
> > > > make: *** [subdir-i386-linux-user] Error 2
> > > 
> > > I can't reproduce the problem (i386 log below). Did you run make clean?
> > > 
> > 
> > Yes 'make clean' or even 'git clean -fdx' doesn't change anything, the
> > problem is still there.
> > 
> 
> OTOH, using configure --disable-system workarounds the problem.
> 

Some more debugging output:

| gcc -Wl,--warn-common -g -m64  -Wl,-T../config-host.ld -Wl,-T,/home/aurel32/git/qemu/x86_64.ld  -o qemu-i386 main.o syscall.o strace.o mmap.o signal.o thunk.o elfload.o linuxload.o uaccess.o gdbstub.o gdbstub-xml.o envlist.o path.o tcg-runtime.o host-utils.o vm86.o cutils-user.o cache-utils-user.o ioport-user.o -Wl,--whole-archive libqemu.a -Wl,--no-whole-archive -lrt -lpthread  -lm
| gcc: tcg-runtime.o: No such file or directory
| gcc: host-utils.o: No such file or directory
| make[1]: *** [qemu-i386] Error 1
| make[1]: Leaving directory `/home/aurel32/git/qemu/i386-linux-user'
| make: *** [subdir-i386-linux-user] Error 2
| aurel32@volta:~/git/qemu (master)$ make  -C i386-linux-user V="1" TARGET_DIR="i386-linux-user/" host-utils.o tcg-runtime.o
| make: Entering directory `/home/aurel32/git/qemu/i386-linux-user'
| make: `/home/aurel32/git/qemu/host-utils.o' is up to date.
| make: `/home/aurel32/git/qemu/tcg-runtime.o' is up to date.
| make: Leaving directory `/home/aurel32/git/qemu/i386-linux-user'

If I remove the host-utils.o and tcg-runtime.o that have been created by
the system builds (in the root directory), then they are built in the 
i386-linux-user/ directory and the build succeeded.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net