From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mrp1b-0000E0-Fj
	for qemu-devel@nongnu.org; Sun, 27 Sep 2009 04:22:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mrp1W-0008Ub-6q
	for qemu-devel@nongnu.org; Sun, 27 Sep 2009 04:22:30 -0400
Received: from [199.232.76.173] (port=41021 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mrp1V-0008U3-VJ
	for qemu-devel@nongnu.org; Sun, 27 Sep 2009 04:22:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62841)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1Mrp1V-0007rt-A7
	for qemu-devel@nongnu.org; Sun, 27 Sep 2009 04:22:25 -0400
Date: Sun, 27 Sep 2009 10:20:20 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090927082020.GA23513@redhat.com>
References: <20090923200635.GA21246@redhat.com>
	<f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <f43fc5580909241050jc8b82fbsb25eef096f8105eb@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On Thu, Sep 24, 2009 at 08:50:11PM +0300, Blue Swirl wrote:
> On Wed, Sep 23, 2009 at 11:06 PM, Michael S. Tsirkin <mst@redhat.com> w=
rote:
> > This creates target.c, which builds per-target, and makes it possible
> > for devices to become target-independent. =A0Use it in msix, revertin=
g
> > part of 5e520a7d500ec2569d22d80f9ef4272a34cb3c80, as we no longer hav=
e
> > to pass target page around.
>=20
> > +unsigned target_page_align(unsigned value)
> > +{
> > + =A0 =A0 =A0 return TARGET_PAGE_ALIGN(value);
> > +}
>=20
> This must be:
> target_phys_addr_t target_page_align(target_phys_addr_t value)

Thinking about this some more, this function just says "align a value to
page size". The value might not be a bus address at all, and indeed with
msix use, it is not. Makes sense?

--=20
MST