From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsWhs-00084y-AK
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 03:01:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsWhn-000831-8t
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 03:01:03 -0400
Received: from [199.232.76.173] (port=34841 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsWhn-00082v-5s
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 03:00:59 -0400
Received: from mx20.gnu.org ([199.232.41.8]:3459)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <mst@redhat.com>) id 1MsWhm-0003LM-LN
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 03:00:58 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MsWhl-0001lP-OL
	for qemu-devel@nongnu.org; Tue, 29 Sep 2009 03:00:58 -0400
Date: Tue, 29 Sep 2009 08:58:56 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090929065856.GC25389@redhat.com>
References: <20090908075831.GA9875@redhat.com>
	<200909212039.01126.rusty@rustcorp.com.au>
	<4AB7A01A.3000206@redhat.com> <4AB8992B.7070709@redhat.com>
	<4AB8DD53.7070806@redhat.com> <4AB8DECA.3090908@redhat.com>
	<4AB8E88C.4040103@redhat.com> <4AB980E6.2070203@codemonkey.ws>
	<4AB9AA8E.7060800@third-harmonic.com> <4AC1A49A.1010308@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4AC1A49A.1010308@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config
	breakage
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: john cooper <john.cooper@redhat.com>
Cc: john cooper <john.cooper@third-harmonic.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, jens.axboe@oracle.com, Vadim Rozenfeld <vrozenfe@redhat.com>

On Tue, Sep 29, 2009 at 02:09:30AM -0400, john cooper wrote:
> This is a correction to the previous version
> which violated the PCI config space 256 byte
> limitation.
> 
> The crux of the feature is simply passing a qemu
> received virtio serial number to/through the guest
> driver and making it available to guest userspace
> via a preexisting interface.
> 
> To accomplish this, ATA IDENTIFY data as implemented
> by the HDIO_GET_IDENTITY ioctl is returned to the
> caller for the virtio_blk drive of interest.  Content
> of this identify structure is created by qemu and
> passed wholesale to guest userspace without
> interpretation by the guest driver.
> 
> The change this patch implements is passing of the
> identify data through a mapping established by
> PCI BAR #5 rather than the PCI config area, the
> latter of which resulted in the above breakage.

Using bar per feature we'll quickly run out of BARs.
We already use a BAR for MSI-X - let's add
ATA identity there?

> virtio_blk with this patch now pulls the information
> from the mapped bar area and includes minimal
> scaffolding to help map bars external to virtio_pci.
> 
> -john
> 
> 
> -- 
> john.cooper@redhat.com