From: "Michael S. Tsirkin" <mst@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCHv4 1/2] fix comment on cpu_register_physical_memory_offset
Date: Tue, 29 Sep 2009 18:53:16 +0200 [thread overview]
Message-ID: <20090929165315.GB14365@redhat.com> (raw)
In-Reply-To: <cover.1254242992.git.mst@redhat.com>
We don't require full pages in cpu_register_physical_memory,
except for RAM.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
exec.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index c82e767..be3c682 100644
--- a/exec.c
+++ b/exec.c
@@ -2291,8 +2291,9 @@ static void *subpage_init (target_phys_addr_t base, ram_addr_t *phys,
} \
} while (0)
-/* register physical memory. 'size' must be a multiple of the target
- page size. If (phys_offset & ~TARGET_PAGE_MASK) != 0, then it is an
+/* register physical memory.
+ For RAM, 'size' must be a multiple of the target page size.
+ If (phys_offset & ~TARGET_PAGE_MASK) != 0, then it is an
io memory page. The address used when calling the IO function is
the offset from the start of the region, plus region_offset. Both
start_addr and region_offset are rounded down to a page boundary
--
1.6.5.rc2
next parent reply other threads:[~2009-09-29 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1254242992.git.mst@redhat.com>
2009-09-29 16:53 ` Michael S. Tsirkin [this message]
2009-09-29 16:53 ` [Qemu-devel] [PATCHv4 2/2] qemu: clean up target page usage in msix Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929165315.GB14365@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).