From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Msfz5-0007La-Ou for qemu-devel@nongnu.org; Tue, 29 Sep 2009 12:55:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Msfyw-0007FV-V1 for qemu-devel@nongnu.org; Tue, 29 Sep 2009 12:55:24 -0400 Received: from [199.232.76.173] (port=47561 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Msfyw-0007FH-N9 for qemu-devel@nongnu.org; Tue, 29 Sep 2009 12:55:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52405) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Msfyv-0001eX-Rw for qemu-devel@nongnu.org; Tue, 29 Sep 2009 12:55:18 -0400 Date: Tue, 29 Sep 2009 18:53:16 +0200 From: "Michael S. Tsirkin" Message-ID: <20090929165315.GB14365@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] [PATCHv4 1/2] fix comment on cpu_register_physical_memory_offset List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl , Anthony Liguori , qemu-devel@nongnu.org We don't require full pages in cpu_register_physical_memory, except for RAM. Signed-off-by: Michael S. Tsirkin --- exec.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index c82e767..be3c682 100644 --- a/exec.c +++ b/exec.c @@ -2291,8 +2291,9 @@ static void *subpage_init (target_phys_addr_t base, ram_addr_t *phys, } \ } while (0) -/* register physical memory. 'size' must be a multiple of the target - page size. If (phys_offset & ~TARGET_PAGE_MASK) != 0, then it is an +/* register physical memory. + For RAM, 'size' must be a multiple of the target page size. + If (phys_offset & ~TARGET_PAGE_MASK) != 0, then it is an io memory page. The address used when calling the IO function is the offset from the start of the region, plus region_offset. Both start_addr and region_offset are rounded down to a page boundary -- 1.6.5.rc2